A* Searching Algorithm Added with README file #11735
Conversation
algorithms-keeper
bot
added
documentation
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| class Cell: | ||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| # Check if a cell is valid (within the grid) | ||
|
|
||
|
|
||
| def is_valid(row, col): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file A_star_searching_algorithm/A_star_search.py, please provide doctest for the function is_valid
Please provide return type hint for the function: is_valid. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: row
Please provide type hint for the parameter: col
| # Check if a cell is unblocked | ||
|
|
||
|
|
||
| def is_unblocked(grid, row, col): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file A_star_searching_algorithm/A_star_search.py, please provide doctest for the function is_unblocked
Please provide return type hint for the function: is_unblocked. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: grid
Please provide type hint for the parameter: row
Please provide type hint for the parameter: col
| # Check if a cell is the destination | ||
|
|
||
|
|
||
| def is_destination(row, col, dest): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file A_star_searching_algorithm/A_star_search.py, please provide doctest for the function is_destination
Please provide return type hint for the function: is_destination. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: row
Please provide type hint for the parameter: col
Please provide type hint for the parameter: dest
| # Calculate the heuristic value of a cell (Euclidean distance to destination) | ||
|
|
||
|
|
||
| def calculate_h_value(row, col, dest): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file A_star_searching_algorithm/A_star_search.py, please provide doctest for the function calculate_h_value
Please provide return type hint for the function: calculate_h_value. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: row
Please provide type hint for the parameter: col
Please provide type hint for the parameter: dest
for more information, see https://pre-commit.ci
Fix #11732
Describe your change:
Checklist: