Skip to content

Reenable files when TensorFlow supports the current Python #11318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MaximSmolskiy
Copy link
Member

@MaximSmolskiy MaximSmolskiy commented Mar 11, 2024

Describe your change:

Reenable files when TensorFlow supports the current Python

Resolve #11317

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Mar 11, 2024
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Mar 11, 2024
@MaximSmolskiy MaximSmolskiy force-pushed the reenable-files-when-tensorflow-supports-the-current-python branch from f521dd5 to 97b7f7b Compare March 11, 2024 08:05
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Mar 11, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Mar 11, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Mar 11, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Mar 11, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Mar 11, 2024
@MaximSmolskiy MaximSmolskiy changed the title Try to reenable files when TensorFlow supports the current Python Reenable files when TensorFlow supports the current Python Mar 11, 2024
Copy link

@themanoftalent themanoftalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some docstrings and comments that contain minor typographical errors or awkward phrasings that could be improved for clarity and readability.

@cclauss cclauss enabled auto-merge (squash) March 12, 2024 08:35
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cclauss cclauss merged commit fd27953 into TheAlgorithms:master Mar 12, 2024
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Mar 12, 2024
@cclauss
Copy link
Member

cclauss commented Mar 12, 2024

@themanoftalent Please create a separate pull request to fix #11318 (review)

@MaximSmolskiy MaximSmolskiy deleted the reenable-files-when-tensorflow-supports-the-current-python branch March 12, 2024 09:05
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
…thms#11318)

* Remove python_version < '3.12' for tensorflow

* Reenable dynamic_programming/k_means_clustering_tensorflow.py

* updating DIRECTORY.md

* Try to fix ruff

* Try to fix ruff

* Try to fix ruff

* Try to fix ruff

* Try to fix ruff

* Reenable machine_learning/lstm/lstm_prediction.py

* updating DIRECTORY.md

* Try to fix ruff

* Reenable computer_vision/cnn_classification.py

* updating DIRECTORY.md

* Reenable neural_network/input_data.py

* updating DIRECTORY.md

* Try to fix ruff

* Try to fix ruff

* Try to fix mypy

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Try to fix ruff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: MaximSmolskiy <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TensorFlow in FINALLY compatible with Python 3.12
3 participants