Skip to content

binarySearch #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2022
Merged

binarySearch #884

merged 3 commits into from
Feb 16, 2022

Conversation

AbmSourav
Copy link
Contributor

  • Parameters added according to the convention
  • Early return base case added

#883

@raklaptudirm raklaptudirm linked an issue Feb 16, 2022 that may be closed by this pull request
Required parameter best practice, avoid nested if block for better performance and readability #883
Closed
raklaptudirm
raklaptudirm requested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your code with standard.js.

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm feature Adds a new feature code style issue Failing style checks labels Feb 16, 2022
@raklaptudirm raklaptudirm merged commit 833d05d into TheAlgorithms:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm code style issue Failing style checks feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required parameter best practice, avoid nested if block for better performance and readability
2 participants
@AbmSourav @raklaptudirm