Required parameter best practice, avoid nested if block for better performance and readability #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

AbmSourav opened this issue Feb 16, 2022 · 0 comments · Fixed by #884

Contributor

AbmSourav commented Feb 16, 2022

binarySearch

required parameters and optional parameters are ordered in a mixed manner. A common programming convention is adding required parameters at the left and optional parameters at the right.
In recursive function, early return base case is better for performance and readability.

AbmSourav mentioned this issue

binarySearch #884

Merged

raklaptudirm linked a pull request

that will close this issue

binarySearch #884

Merged

raklaptudirm closed this as completed in #884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment