Skip to content

Extended Eucliedian Algorithm added to Maths folder #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 21, 2021
Merged

Extended Eucliedian Algorithm added to Maths folder #799

merged 5 commits into from
Oct 21, 2021

Conversation

VinWare
Copy link
Contributor

@VinWare VinWare commented Oct 21, 2021 •
edited
Loading

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
    Another algorithm file (MaxProductOfThree.js) has been changed due to npm run style. No logical change has been performed. npm test runs with all successful

@VinWare VinWare requested a review from raklaptudirm as a code owner October 21, 2021 09:42
@VinWare
Copy link
Contributor Author

VinWare commented Oct 21, 2021

Fixed the error from workflow in the latest commit

raklaptudirm
raklaptudirm requested changes Oct 21, 2021
View reviewed changes
@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Oct 21, 2021
@VinWare VinWare requested a review from raklaptudirm October 21, 2021 13:12
@raklaptudirm raklaptudirm removed the changes required This pull request needs changes label Oct 21, 2021
@raklaptudirm raklaptudirm merged commit 8381e5e into TheAlgorithms:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VinWare @raklaptudirm