Skip to content

Commit 8381e5e

Browse files
authored
chore: Merge pull request #799 from VinWare/master
Extended Eucliedian Algorithm added to Maths folder
2 parents 7148b38 + e92e2e3 commit 8381e5e

File tree

7 files changed

+118
-32
lines changed

7 files changed

+118
-32
lines changed

Conversions/MeterToFeetConversion.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// Foot: https://en.wikipedia.org/wiki/Foot_(unit)
22
const feetToMeter = (feet) => {
3-
return feet*0.3048;
3+
return feet * 0.3048
44
}
55

66
const meterToFeet = (meter) => {
7-
return meter/0.3048;
7+
return meter / 0.3048
88
}
99

10-
export { feetToMeter, meterToFeet }
10+
export { feetToMeter, meterToFeet }

Conversions/test/MeterToFeetConversion.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { meterToFeet, feetToMeter } from "../MeterToFeetConversion";
1+
import { meterToFeet, feetToMeter } from '../MeterToFeetConversion'
22

33
describe('Testing conversion of Meter to Feet', () => {
44
it('with feet value', () => {
@@ -10,4 +10,4 @@ describe('Testing conversion of Feet to Meter', () => {
1010
it('with feet value', () => {
1111
expect(feetToMeter(10)).toBe(3.048)
1212
})
13-
})
13+
})

Dynamic-Programming/MaxProductOfThree.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
* @param {number[]} arrayItems
66
* @returns number
77
*/
8-
export function maxProductOfThree(arrayItems) {
8+
export function maxProductOfThree (arrayItems) {
99
// if size is less than 3, no triplet exists
10-
let n = arrayItems.length
10+
const n = arrayItems.length
1111
if (n < 3) throw new Error('Triplet cannot exist with the given array')
12-
let max1 = arrayItems[0],
13-
max2 = -1,
14-
max3 = -1,
15-
min1 = arrayItems[0],
16-
min2 = -1
12+
let max1 = arrayItems[0]
13+
let max2 = -1
14+
let max3 = -1
15+
let min1 = arrayItems[0]
16+
let min2 = -1
1717
for (let i = 1; i < n; i++) {
1818
if (arrayItems[i] > max1) {
1919
max3 = max2
@@ -32,7 +32,7 @@ export function maxProductOfThree(arrayItems) {
3232
min2 = arrayItems[i]
3333
}
3434
}
35-
let prod1 = max1 * max2 * max3,
36-
prod2 = max1 * min1 * min2
35+
const prod1 = max1 * max2 * max3
36+
const prod2 = max1 * min1 * min2
3737
return Math.max(prod1, prod2)
3838
}

Maths/ExtendedEuclideanGCD.js

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
/**
2+
* Problem statement and explanation: https://en.wikipedia.org/wiki/Extended_Euclidean_algorithm
3+
*
4+
* This algorithm plays an important role for modular arithmetic, and by extension for cyptography algorithms
5+
*
6+
* Basic explanation:
7+
* The Extended Euclidean algorithm is a modification of the standard Euclidean GCD algorithm.
8+
* It allows to calculate coefficients x and y for the equation:
9+
* ax + by = gcd(a,b)
10+
*
11+
* This is called Bézout's identity and the coefficients are called Bézout coefficients
12+
*
13+
* The algorithm uses the Euclidean method of getting remainder:
14+
* r_i+1 = r_i-1 - qi*ri
15+
* and applies it to series s and t (with same quotient q at each stage)
16+
* When r_n reaches 0, the value r_n-1 gives the gcd, and s_n-1 and t_n-1 give the coefficients
17+
*
18+
* This implementation uses an iterative approach to calculate the values
19+
*/
20+
21+
/**
22+
*
23+
* @param {Number} arg1 first argument
24+
* @param {Number} arg2 second argument
25+
* @returns Array with GCD and first and second Bézout coefficients
26+
*/
27+
const extendedEuclideanGCD = (arg1, arg2) => {
28+
if (typeof arg1 !== 'number' || typeof arg2 !== 'number') throw new TypeError('Not a Number')
29+
if (arg1 < 1 || arg2 < 1) throw new TypeError('Must be positive numbers')
30+
31+
// Make the order of coefficients correct, as the algorithm assumes r0 > r1
32+
if (arg1 < arg2) {
33+
const res = extendedEuclideanGCD(arg2, arg1)
34+
const temp = res[1]
35+
res[1] = res[2]
36+
res[2] = temp
37+
return res
38+
}
39+
40+
// At this point arg1 > arg2
41+
42+
// Remainder values
43+
let r0 = arg1
44+
let r1 = arg2
45+
46+
// Coefficient1 values
47+
let s0 = 1
48+
let s1 = 0
49+
50+
// Coefficient 2 values
51+
let t0 = 0
52+
let t1 = 1
53+
54+
while (r1 !== 0) {
55+
const q = Math.floor(r0 / r1)
56+
57+
const r2 = r0 - r1 * q
58+
const s2 = s0 - s1 * q
59+
const t2 = t0 - t1 * q
60+
61+
r0 = r1
62+
r1 = r2
63+
s0 = s1
64+
s1 = s2
65+
t0 = t1
66+
t1 = t2
67+
}
68+
return [r0, s0, t0]
69+
}
70+
71+
export { extendedEuclideanGCD }

Maths/FigurateNumber.js

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
/**
2-
Problem Statment and Explanation :
2+
Problem Statment and Explanation :
33
Triangular => https://en.wikipedia.org/wiki/Triangular_number
44
Tetrahedral => https://en.wikipedia.org/wiki/Tetrahedral_number
55
Pentatope => https://en.wikipedia.org/wiki/Pentatope_number
66
7-
8-
Example:
7+
Example:
98
Triangular => (0, 1, 3, 6, 10, 15, 21, 28, 36, 45)
109
Tetrahedral => (1, 4, 10, 20, 35, 56, 84, 120, 165,)
1110
Pentatope => (1, 5, 15, 35, 70, 126, 210, 330, 495)
1211
*/
1312

1413
/**
15-
*
16-
* @param {*} number
17-
* @returns
14+
*
15+
* @param {*} number
16+
* @returns
1817
*/
1918
const isTriangular = (number) => {
2019
for (let i = 0; i <= number; i++) {
@@ -28,9 +27,9 @@ const isTriangular = (number) => {
2827
}
2928

3029
/**
31-
*
32-
* @param {*} number
33-
* @returns
30+
*
31+
* @param {*} number
32+
* @returns
3433
*/
3534
const isTetrahedral = (number) => {
3635
for (let i = 1; i <= number; i++) {
@@ -43,9 +42,9 @@ const isTetrahedral = (number) => {
4342
return false
4443
}
4544
/**
46-
*
47-
* @param {*} number
48-
* @returns
45+
*
46+
* @param {*} number
47+
* @returns
4948
*/
5049
const isPentatope = (number) => {
5150
for (let i = 1; i <= number; i++) {
@@ -59,11 +58,11 @@ const isPentatope = (number) => {
5958
}
6059

6160
/**
62-
*
63-
* @param {*} number
64-
* @returns
61+
*
62+
* @param {*} number
63+
* @returns
6564
*/
66-
let checkAll = (number) => {
65+
const checkAll = (number) => {
6766
return {
6867
isTriangular: isTriangular(number),
6968
isTetrahedral: isTetrahedral(number),
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import { extendedEuclideanGCD } from '../ExtendedEuclideanGCD'
2+
3+
describe('extendedEuclideanGCD', () => {
4+
it('should return valid values in order for positive arguments', () => {
5+
expect(extendedEuclideanGCD(240, 46)).toMatchObject([2, -9, 47])
6+
expect(extendedEuclideanGCD(46, 240)).toMatchObject([2, 47, -9])
7+
})
8+
it('should give error on non-positive arguments', () => {
9+
expect(() => extendedEuclideanGCD(0, 240)).toThrowError(new TypeError('Must be positive numbers'))
10+
expect(() => extendedEuclideanGCD(46, -240)).toThrowError(new TypeError('Must be positive numbers'))
11+
})
12+
it('should give error on non-numeric arguments', () => {
13+
expect(() => extendedEuclideanGCD('240', 46)).toThrowError(new TypeError('Not a Number'))
14+
expect(() => extendedEuclideanGCD([240, 46])).toThrowError(new TypeError('Not a Number'))
15+
})
16+
})

Maths/test/FigurateNumber.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ describe('FigurateNumber', () => {
5454
})
5555
/** End */
5656

57-
it('Check All : should return all true',() => {
57+
it('Check All : should return all true', () => {
5858
expect(checkAll(1)).toEqual({
5959
isTriangular: true,
6060
isTetrahedral: true,
6161
isPentatope: true
6262
})
6363
})
6464

65-
it('Check All : should return all true,true,false',() => {
65+
it('Check All : should return all true,true,false', () => {
6666
expect(checkAll(15)).toEqual({
6767
isTriangular: true,
6868
isTetrahedral: false,

0 commit comments

Comments
 (0)