Skip to content

Added BellmanFord #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2021
Merged

Added BellmanFord #679

merged 6 commits into from
Sep 9, 2021

Conversation

Mayank17M
Copy link
Member

@Mayank17M Mayank17M commented Sep 4, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Mayank17M
Copy link
Member Author

@raklaptudirm Please check if it is appropriate now. Thanks!

@raklaptudirm
Copy link
Member

Please use standard.js to style your code.

@raklaptudirm raklaptudirm added the code style issue Failing style checks label Sep 5, 2021
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. I should suggest moving the tests into a separate jest file in the test/ sub directory. You can refer to the other test files if you need so. If you do not feel like doing it, this code is also acceptable, but it will be better if you move the tests.

@raklaptudirm raklaptudirm merged commit d49cf9f into TheAlgorithms:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code style issue Failing style checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants