feat: optimize SortUtils.swap by skipping operations for equal indices
#5266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxkm
requested review from
yanglbme,
vil02 and
BamaCharanChhandogi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5266 +/- ##
============================================
+ Coverage 39.94% 39.96% +0.01%
- Complexity 2456 2458 +2
============================================
Files 519 519
Lines 15487 15488 +1
Branches 2957 2957
============================================
+ Hits 6187 6190 +3
+ Misses 9008 9007 -1
+ Partials 292 291 -1 ☔ View full report in Codecov by Sentry. |
vil02
requested changes
Jun 29, 2024
There was a problem hiding this comment.
It is a pity that Collections.swap is not directly applicable.
Yes. Maybe, if all the sorting is in lists. But that looks like perfectionism. But sorting implementations using arrays look more traditional from a computer science perspective. |
vil02
requested changes
Jun 29, 2024
Such calls should be excluded.
vil02
approved these changes
Jun 29, 2024
vil02
changed the title
SortUtils.swap by skipping operations for equal indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding check if indeces are not equals, for swap method in SortUtils.
According to this suggestion #5265 (comment)
clang-format -i --style=file path/to/your/file.java