Skip to content

refactor: SelectionSort like classes and their tests #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2024
Merged

refactor: SelectionSort like classes and their tests #5265

merged 5 commits into from
Jun 29, 2024

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jun 28, 2024

Refactor: Adding test common approach, adding javadocs, renaming variables

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.96%. Comparing base (0087444) to head (f44339e).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5265      +/-   ##
============================================
+ Coverage     39.95%   39.96%   +0.01%     
  Complexity     2458     2458              
============================================
  Files           519      519              
  Lines         15501    15487      -14     
  Branches       2965     2957       -8     
============================================
- Hits           6193     6190       -3     
+ Misses         9017     9007      -10     
+ Partials        291      290       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alxkm
Copy link
Contributor Author

alxkm commented Jun 28, 2024

In this pull request, also changed SortingAlgorithmTest to customize size of generated array. For recursive selection sort, time to time this was an stackOverFlow, to avoid failed builds, size of generated arrray can be changed by demand.

@alxkm
Copy link
Contributor Author

alxkm commented Jun 28, 2024

Hello @vil02

This PR should fix this problem https://github.com/TheAlgorithms/Java/actions/runs/9708998343/job/26796827946

I already runned this bunch of times and no such cases was.

@alxkm alxkm requested a review from vil02 June 29, 2024 07:59
@vil02 vil02 changed the title Refactor: SelectionSort refactor: SelectionSort like classes and their tests Jun 29, 2024
@vil02 vil02 merged commit 20e7a3a into TheAlgorithms:master Jun 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants