style: enable MissingSwitchDefault in checkstyle
#5176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5176 +/- ##
============================================
- Coverage 38.60% 38.58% -0.03%
Complexity 2378 2378
============================================
Files 516 516
Lines 15391 15403 +12
Branches 2957 2958 +1
============================================
+ Hits 5942 5943 +1
- Misses 9163 9174 +11
Partials 286 286 ☔ View full report in Codecov by Sentry. |
vil02
requested changes
May 26, 2024
Comment on lines
60
to
62
| System.out.println("Unexpected value: " + a[mid]); | ||
| mid++; | ||
| break; |
There was a problem hiding this comment.
Suggested change
| System.out.println("Unexpected value: " + a[mid]); | |
| mid++; | |
| break; | |
| throw new IllegalArgumentException("Unexpected value: " + a[mid]); |
Comment on lines
35
to
37
| System.out.println("Unexpected value: " + a[mid]); | ||
| mid++; | ||
| break; |
There was a problem hiding this comment.
Suggested change
| System.out.println("Unexpected value: " + a[mid]); | |
| mid++; | |
| break; | |
| throw new IllegalArgumentException("Unexpected value: " + a[mid]); |
Comment on lines
33
to
35
| // Optional: Handle unexpected characters if needed | ||
| System.out.println("Unexpected character: " + c); | ||
| return false; |
There was a problem hiding this comment.
Suggested change
| // Optional: Handle unexpected characters if needed | |
| System.out.println("Unexpected character: " + c); | |
| return false; | |
| throw new IllegalArgumentException("Unexpected character: " + c); |
There was a problem hiding this comment.
Please revert all of the non-necessary changes and create a new PR with them.
26 tasks
vil02
changed the title
MissingSwitchDefault in checkstyleMissingSwitchDefault in checkstyle
BamaCharanChhandogi
force-pushed
the
CheckStyle
branch
from
69877ba to
6072f00
Compare
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #5119
clang-format -i --style=file path/to/your/file.java