Skip to content

Commit 6072f00

Browse files
BamaCharanChhandogiBamaCharanChhandogi
authored
Merge branch 'TheAlgorithms:master' into master
2 parents adf6df5 + 9eaa2bb commit 6072f00

File tree

94 files changed

+358
-185
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+358
-185
lines changed

‎checkstyle.xml

+3-3
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,13 @@
109109
<!-- Checks for Naming Conventions. -->
110110
<!-- See https://checkstyle.org/checks/naming/index.html -->
111111
<module name="ConstantName"/>
112-
<!-- TODO <module name="LocalFinalVariableName"/> -->
112+
<module name="LocalFinalVariableName"/>
113113
<!-- TODO <module name="LocalVariableName"/> -->
114114
<!-- TODO <module name="MemberName"/> -->
115115
<!-- TODO <module name="MethodName"/> -->
116116
<module name="PackageName"/>
117117
<!-- TODO <module name="ParameterName"/> -->
118-
<!-- TODO <module name="StaticVariableName"/> -->
118+
<module name="StaticVariableName"/>
119119
<!-- TODO <module name="TypeName"/> -->
120120

121121
<!-- Checks for imports -->
@@ -167,7 +167,7 @@
167167
<module name="InnerAssignment"/>
168168
<!-- TODO <module name="MagicNumber"/> -->
169169
<!-- TODO <module name="MissingSwitchDefault"/> -->
170-
<!-- TODO <module name="MultipleVariableDeclarations"/> -->
170+
<module name="MultipleVariableDeclarations"/>
171171
<module name="SimplifyBooleanExpression"/>
172172
<module name="SimplifyBooleanReturn"/>
173173

‎pmd-exclude.properties

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ com.thealgorithms.datastructures.queues.PriorityQueue=UselessParentheses
2525
com.thealgorithms.datastructures.stacks.NodeStack=UnnecessaryFullyQualifiedName,UnusedFormalParameter
2626
com.thealgorithms.datastructures.stacks.StackArray=UselessParentheses
2727
com.thealgorithms.datastructures.trees.CheckBinaryTreeIsValidBST=UselessParentheses
28-
com.thealgorithms.datastructures.trees.Point=OverrideBothEqualsAndHashcode
2928
com.thealgorithms.datastructures.trees.SegmentTree=UselessParentheses
3029
com.thealgorithms.devutils.nodes.LargeTreeNode=UselessParentheses
3130
com.thealgorithms.devutils.nodes.SimpleNode=UselessParentheses

‎pom.xml

-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@
8282
<arg>-Xlint:-try</arg>
8383
<arg>-Xlint:-unchecked</arg>
8484
<arg>-Xlint:-lossy-conversions</arg>
85-
<arg>-Xlint:-this-escape</arg>
8685
<arg>-Werror</arg>
8786
</compilerArgs>
8887
</configuration>

‎spotbugs-exclude.xml

-3
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,6 @@
8080
<Match>
8181
<Bug pattern="SS_SHOULD_BE_STATIC" />
8282
</Match>
83-
<Match>
84-
<Bug pattern="HE_EQUALS_USE_HASHCODE" />
85-
</Match>
8683
<Match>
8784
<Bug pattern="IT_NO_SUCH_ELEMENT" />
8885
</Match>

‎src/main/java/com/thealgorithms/backtracking/PowerSum.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
*/
99
public class PowerSum {
1010

11-
private int count = 0, sum = 0;
11+
private int count = 0;
12+
private int sum = 0;
1213

1314
public int powSum(int N, int X) {
1415
Sum(N, X, 1);

‎src/main/java/com/thealgorithms/ciphers/Blowfish.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1175,7 +1175,8 @@ private void keyGenerate(String key) {
11751175

11761176
// round function
11771177
private String round(int time, String plainText) {
1178-
String left, right;
1178+
String left;
1179+
String right;
11791180
left = plainText.substring(0, 8);
11801181
right = plainText.substring(8, 16);
11811182
left = xor(left, P[time]);

‎src/main/java/com/thealgorithms/ciphers/DES.java

+42-33
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
public class DES {
99

1010
private String key;
11-
private String[] subKeys;
11+
private final String[] subKeys;
1212

1313
private void sanitize(String key) {
1414
int length = key.length();
@@ -32,55 +32,57 @@ public void setKey(String key) {
3232
this.key = key;
3333
}
3434

35-
// Permutation table to convert initial 64 bit key to 56 bit key
36-
private static int[] PC1 = {57, 49, 41, 33, 25, 17, 9, 1, 58, 50, 42, 34, 26, 18, 10, 2, 59, 51, 43, 35, 27, 19, 11, 3, 60, 52, 44, 36, 63, 55, 47, 39, 31, 23, 15, 7, 62, 54, 46, 38, 30, 22, 14, 6, 61, 53, 45, 37, 29, 21, 13, 5, 28, 20, 12, 4};
35+
// Permutation table to convert initial 64-bit key to 56 bit key
36+
private static final int[] PC1 = {57, 49, 41, 33, 25, 17, 9, 1, 58, 50, 42, 34, 26, 18, 10, 2, 59, 51, 43, 35, 27, 19, 11, 3, 60, 52, 44, 36, 63, 55, 47, 39, 31, 23, 15, 7, 62, 54, 46, 38, 30, 22, 14, 6, 61, 53, 45, 37, 29, 21, 13, 5, 28, 20, 12, 4};
3737

3838
// Lookup table used to shift the initial key, in order to generate the subkeys
39-
private static int[] KEY_SHIFTS = {1, 1, 2, 2, 2, 2, 2, 2, 1, 2, 2, 2, 2, 2, 2, 1};
39+
private static final int[] KEY_SHIFTS = {1, 1, 2, 2, 2, 2, 2, 2, 1, 2, 2, 2, 2, 2, 2, 1};
4040

4141
// Table to convert the 56 bit subkeys to 48 bit subkeys
42-
private static int[] PC2 = {14, 17, 11, 24, 1, 5, 3, 28, 15, 6, 21, 10, 23, 19, 12, 4, 26, 8, 16, 7, 27, 20, 13, 2, 41, 52, 31, 37, 47, 55, 30, 40, 51, 45, 33, 48, 44, 49, 39, 56, 34, 53, 46, 42, 50, 36, 29, 32};
42+
private static final int[] PC2 = {14, 17, 11, 24, 1, 5, 3, 28, 15, 6, 21, 10, 23, 19, 12, 4, 26, 8, 16, 7, 27, 20, 13, 2, 41, 52, 31, 37, 47, 55, 30, 40, 51, 45, 33, 48, 44, 49, 39, 56, 34, 53, 46, 42, 50, 36, 29, 32};
4343

44-
// Initial permutatation of each 64 but message block
45-
private static int[] IP = {58, 50, 42, 34, 26, 18, 10, 2, 60, 52, 44, 36, 28, 20, 12, 4, 62, 54, 46, 38, 30, 22, 14, 6, 64, 56, 48, 40, 32, 24, 16, 8, 57, 49, 41, 33, 25, 17, 9, 1, 59, 51, 43, 35, 27, 19, 11, 3, 61, 53, 45, 37, 29, 21, 13, 5, 63, 55, 47, 39, 31, 23, 15, 7};
44+
// Initial permutation of each 64 but message block
45+
private static final int[] IP = {58, 50, 42, 34, 26, 18, 10, 2, 60, 52, 44, 36, 28, 20, 12, 4, 62, 54, 46, 38, 30, 22, 14, 6, 64, 56, 48, 40, 32, 24, 16, 8, 57, 49, 41, 33, 25, 17, 9, 1, 59, 51, 43, 35, 27, 19, 11, 3, 61, 53, 45, 37, 29, 21, 13, 5, 63, 55, 47, 39, 31, 23, 15, 7};
4646

4747
// Expansion table to convert right half of message blocks from 32 bits to 48 bits
48-
private static int[] expansion = {32, 1, 2, 3, 4, 5, 4, 5, 6, 7, 8, 9, 8, 9, 10, 11, 12, 13, 12, 13, 14, 15, 16, 17, 16, 17, 18, 19, 20, 21, 20, 21, 22, 23, 24, 25, 24, 25, 26, 27, 28, 29, 28, 29, 30, 31, 32, 1};
48+
private static final int[] EXPANSION = {32, 1, 2, 3, 4, 5, 4, 5, 6, 7, 8, 9, 8, 9, 10, 11, 12, 13, 12, 13, 14, 15, 16, 17, 16, 17, 18, 19, 20, 21, 20, 21, 22, 23, 24, 25, 24, 25, 26, 27, 28, 29, 28, 29, 30, 31, 32, 1};
4949

5050
// The eight substitution boxes are defined below
51-
private static int[][] s1 = {{14, 4, 13, 1, 2, 15, 11, 8, 3, 10, 6, 12, 5, 9, 0, 7}, {0, 15, 7, 4, 14, 2, 13, 1, 10, 6, 12, 11, 9, 5, 3, 8}, {4, 1, 14, 8, 13, 6, 2, 11, 15, 12, 9, 7, 3, 10, 5, 0}, {15, 12, 8, 2, 4, 9, 1, 7, 5, 11, 3, 14, 10, 0, 6, 13}};
51+
private static final int[][] S1 = {{14, 4, 13, 1, 2, 15, 11, 8, 3, 10, 6, 12, 5, 9, 0, 7}, {0, 15, 7, 4, 14, 2, 13, 1, 10, 6, 12, 11, 9, 5, 3, 8}, {4, 1, 14, 8, 13, 6, 2, 11, 15, 12, 9, 7, 3, 10, 5, 0}, {15, 12, 8, 2, 4, 9, 1, 7, 5, 11, 3, 14, 10, 0, 6, 13}};
5252

53-
private static int[][] s2 = {{15, 1, 8, 14, 6, 11, 3, 4, 9, 7, 2, 13, 12, 0, 5, 10}, {3, 13, 4, 7, 15, 2, 8, 14, 12, 0, 1, 10, 6, 9, 11, 5}, {0, 14, 7, 11, 10, 4, 13, 1, 5, 8, 12, 6, 9, 3, 2, 15}, {13, 8, 10, 1, 3, 15, 4, 2, 11, 6, 7, 12, 0, 5, 14, 9}};
53+
private static final int[][] S2 = {{15, 1, 8, 14, 6, 11, 3, 4, 9, 7, 2, 13, 12, 0, 5, 10}, {3, 13, 4, 7, 15, 2, 8, 14, 12, 0, 1, 10, 6, 9, 11, 5}, {0, 14, 7, 11, 10, 4, 13, 1, 5, 8, 12, 6, 9, 3, 2, 15}, {13, 8, 10, 1, 3, 15, 4, 2, 11, 6, 7, 12, 0, 5, 14, 9}};
5454

55-
private static int[][] s3 = {{10, 0, 9, 14, 6, 3, 15, 5, 1, 13, 12, 7, 11, 4, 2, 8}, {13, 7, 0, 9, 3, 4, 6, 10, 2, 8, 5, 14, 12, 11, 15, 1}, {13, 6, 4, 9, 8, 15, 3, 0, 11, 1, 2, 12, 5, 10, 14, 7}, {1, 10, 13, 0, 6, 9, 8, 7, 4, 15, 14, 3, 11, 5, 2, 12}};
55+
private static final int[][] S3 = {{10, 0, 9, 14, 6, 3, 15, 5, 1, 13, 12, 7, 11, 4, 2, 8}, {13, 7, 0, 9, 3, 4, 6, 10, 2, 8, 5, 14, 12, 11, 15, 1}, {13, 6, 4, 9, 8, 15, 3, 0, 11, 1, 2, 12, 5, 10, 14, 7}, {1, 10, 13, 0, 6, 9, 8, 7, 4, 15, 14, 3, 11, 5, 2, 12}};
5656

57-
private static int[][] s4 = {{7, 13, 14, 3, 0, 6, 9, 10, 1, 2, 8, 5, 11, 12, 4, 15}, {13, 8, 11, 5, 6, 15, 0, 3, 4, 7, 2, 12, 1, 10, 14, 9}, {10, 6, 9, 0, 12, 11, 7, 13, 15, 1, 3, 14, 5, 2, 8, 4}, {3, 15, 0, 6, 10, 1, 13, 8, 9, 4, 5, 11, 12, 7, 2, 14}};
57+
private static final int[][] S4 = {{7, 13, 14, 3, 0, 6, 9, 10, 1, 2, 8, 5, 11, 12, 4, 15}, {13, 8, 11, 5, 6, 15, 0, 3, 4, 7, 2, 12, 1, 10, 14, 9}, {10, 6, 9, 0, 12, 11, 7, 13, 15, 1, 3, 14, 5, 2, 8, 4}, {3, 15, 0, 6, 10, 1, 13, 8, 9, 4, 5, 11, 12, 7, 2, 14}};
5858

59-
private static int[][] s5 = {{2, 12, 4, 1, 7, 10, 11, 6, 8, 5, 3, 15, 13, 0, 14, 9}, {14, 11, 2, 12, 4, 7, 13, 1, 5, 0, 15, 10, 3, 9, 8, 6}, {4, 2, 1, 11, 10, 13, 7, 8, 15, 9, 12, 5, 6, 3, 0, 14}, {11, 8, 12, 7, 1, 14, 2, 13, 6, 15, 0, 9, 10, 4, 5, 3}};
59+
private static final int[][] S5 = {{2, 12, 4, 1, 7, 10, 11, 6, 8, 5, 3, 15, 13, 0, 14, 9}, {14, 11, 2, 12, 4, 7, 13, 1, 5, 0, 15, 10, 3, 9, 8, 6}, {4, 2, 1, 11, 10, 13, 7, 8, 15, 9, 12, 5, 6, 3, 0, 14}, {11, 8, 12, 7, 1, 14, 2, 13, 6, 15, 0, 9, 10, 4, 5, 3}};
6060

61-
private static int[][] s6 = {{12, 1, 10, 15, 9, 2, 6, 8, 0, 13, 3, 4, 14, 7, 5, 11}, {10, 15, 4, 2, 7, 12, 9, 5, 6, 1, 13, 14, 0, 11, 3, 8}, {9, 14, 15, 5, 2, 8, 12, 3, 7, 0, 4, 10, 1, 13, 11, 6}, {4, 3, 2, 12, 9, 5, 15, 10, 11, 14, 1, 7, 6, 0, 8, 13}};
61+
private static final int[][] S6 = {{12, 1, 10, 15, 9, 2, 6, 8, 0, 13, 3, 4, 14, 7, 5, 11}, {10, 15, 4, 2, 7, 12, 9, 5, 6, 1, 13, 14, 0, 11, 3, 8}, {9, 14, 15, 5, 2, 8, 12, 3, 7, 0, 4, 10, 1, 13, 11, 6}, {4, 3, 2, 12, 9, 5, 15, 10, 11, 14, 1, 7, 6, 0, 8, 13}};
6262

63-
private static int[][] s7 = {{4, 11, 2, 14, 15, 0, 8, 13, 3, 12, 9, 7, 5, 10, 6, 1}, {13, 0, 11, 7, 4, 9, 1, 10, 14, 3, 5, 12, 2, 15, 8, 6}, {1, 4, 11, 13, 12, 3, 7, 14, 10, 15, 6, 8, 0, 5, 9, 2}, {6, 11, 13, 8, 1, 4, 10, 7, 9, 5, 0, 15, 14, 2, 3, 12}};
63+
private static final int[][] S7 = {{4, 11, 2, 14, 15, 0, 8, 13, 3, 12, 9, 7, 5, 10, 6, 1}, {13, 0, 11, 7, 4, 9, 1, 10, 14, 3, 5, 12, 2, 15, 8, 6}, {1, 4, 11, 13, 12, 3, 7, 14, 10, 15, 6, 8, 0, 5, 9, 2}, {6, 11, 13, 8, 1, 4, 10, 7, 9, 5, 0, 15, 14, 2, 3, 12}};
6464

65-
private static int[][] s8 = {{13, 2, 8, 4, 6, 15, 11, 1, 10, 9, 3, 14, 5, 0, 12, 7}, {1, 15, 13, 8, 10, 3, 7, 4, 12, 5, 6, 11, 0, 14, 9, 2}, {7, 11, 4, 1, 9, 12, 14, 2, 0, 6, 10, 13, 15, 3, 5, 8}, {2, 1, 14, 7, 4, 10, 8, 13, 15, 12, 9, 0, 3, 5, 6, 11}};
65+
private static final int[][] S8 = {{13, 2, 8, 4, 6, 15, 11, 1, 10, 9, 3, 14, 5, 0, 12, 7}, {1, 15, 13, 8, 10, 3, 7, 4, 12, 5, 6, 11, 0, 14, 9, 2}, {7, 11, 4, 1, 9, 12, 14, 2, 0, 6, 10, 13, 15, 3, 5, 8}, {2, 1, 14, 7, 4, 10, 8, 13, 15, 12, 9, 0, 3, 5, 6, 11}};
6666

67-
private static int[][][] s = {s1, s2, s3, s4, s5, s6, s7, s8};
67+
private static final int[][][] S = {S1, S2, S3, S4, S5, S6, S7, S8};
6868

69-
// Permutation table, used in the feistel function post s-box usage
70-
static int[] permutation = {16, 7, 20, 21, 29, 12, 28, 17, 1, 15, 23, 26, 5, 18, 31, 10, 2, 8, 24, 14, 32, 27, 3, 9, 19, 13, 30, 6, 22, 11, 4, 25};
69+
// Permutation table, used in the Feistel function post s-box usage
70+
static final int[] PERMUTATION = {16, 7, 20, 21, 29, 12, 28, 17, 1, 15, 23, 26, 5, 18, 31, 10, 2, 8, 24, 14, 32, 27, 3, 9, 19, 13, 30, 6, 22, 11, 4, 25};
7171

7272
// Table used for final inversion of the message box after 16 rounds of Feistel Function
73-
static int[] IPinverse = {40, 8, 48, 16, 56, 24, 64, 32, 39, 7, 47, 15, 55, 23, 63, 31, 38, 6, 46, 14, 54, 22, 62, 30, 37, 5, 45, 13, 53, 21, 61, 29, 36, 4, 44, 12, 52, 20, 60, 28, 35, 3, 43, 11, 51, 19, 59, 27, 34, 2, 42, 10, 50, 18, 58, 26, 33, 1, 41, 9, 49, 17, 57, 25};
73+
static final int[] IP_INVERSE = {40, 8, 48, 16, 56, 24, 64, 32, 39, 7, 47, 15, 55, 23, 63, 31, 38, 6, 46, 14, 54, 22, 62, 30, 37, 5, 45, 13, 53, 21, 61, 29, 36, 4, 44, 12, 52, 20, 60, 28, 35, 3, 43, 11, 51, 19, 59, 27, 34, 2, 42, 10, 50, 18, 58, 26, 33, 1, 41, 9, 49, 17, 57, 25};
7474

7575
private String[] getSubkeys(String originalKey) {
76-
StringBuilder permutedKey = new StringBuilder(); // Initial permutation of keys via PC1
77-
int i, j;
76+
StringBuilder permutedKey = new StringBuilder(); // Initial permutation of keys via pc1
77+
int i;
78+
int j;
7879
for (i = 0; i < 56; i++) {
7980
permutedKey.append(originalKey.charAt(PC1[i] - 1));
8081
}
8182
String[] subKeys = new String[16];
8283
String initialPermutedKey = permutedKey.toString();
83-
String C0 = initialPermutedKey.substring(0, 28), D0 = initialPermutedKey.substring(28);
84+
String C0 = initialPermutedKey.substring(0, 28);
85+
String D0 = initialPermutedKey.substring(28);
8486

8587
// We will now operate on the left and right halves of the permutedKey
8688
for (i = 0; i < 16; i++) {
@@ -91,7 +93,7 @@ private String[] getSubkeys(String originalKey) {
9193
D0 = Dn;
9294
}
9395

94-
// Let us shrink the keys to 48 bits (well, characters here) using PC2
96+
// Let us shrink the keys to 48 bits (well, characters here) using pc2
9597
for (i = 0; i < 16; i++) {
9698
String key = subKeys[i];
9799
permutedKey.setLength(0);
@@ -105,7 +107,8 @@ private String[] getSubkeys(String originalKey) {
105107
}
106108

107109
private String XOR(String a, String b) {
108-
int i, l = a.length();
110+
int i;
111+
int l = a.length();
109112
StringBuilder xor = new StringBuilder();
110113
for (i = 0; i < l; i++) {
111114
int firstBit = a.charAt(i) - 48; // 48 is '0' in ascii
@@ -116,7 +119,8 @@ private String XOR(String a, String b) {
116119
}
117120

118121
private String createPaddedString(String s, int desiredLength, char pad) {
119-
int i, l = s.length();
122+
int i;
123+
int l = s.length();
120124
StringBuilder paddedString = new StringBuilder();
121125
int diff = desiredLength - l;
122126
for (i = 0; i < diff; i++) {
@@ -137,7 +141,7 @@ private String feistel(String messageBlock, String key) {
137141
int i;
138142
StringBuilder expandedKey = new StringBuilder();
139143
for (i = 0; i < 48; i++) {
140-
expandedKey.append(messageBlock.charAt(expansion[i] - 1));
144+
expandedKey.append(messageBlock.charAt(EXPANSION[i] - 1));
141145
}
142146
String mixedKey = XOR(expandedKey.toString(), key);
143147
StringBuilder substitutedString = new StringBuilder();
@@ -147,13 +151,13 @@ private String feistel(String messageBlock, String key) {
147151
String block = mixedKey.substring(i, i + 6);
148152
int row = (block.charAt(0) - 48) * 2 + (block.charAt(5) - 48);
149153
int col = (block.charAt(1) - 48) * 8 + (block.charAt(2) - 48) * 4 + (block.charAt(3) - 48) * 2 + (block.charAt(4) - 48);
150-
String substitutedBlock = pad(Integer.toBinaryString(s[i / 6][row][col]), 4);
154+
String substitutedBlock = pad(Integer.toBinaryString(S[i / 6][row][col]), 4);
151155
substitutedString.append(substitutedBlock);
152156
}
153157

154158
StringBuilder permutedString = new StringBuilder();
155159
for (i = 0; i < 32; i++) {
156-
permutedString.append(substitutedString.charAt(permutation[i] - 1));
160+
permutedString.append(substitutedString.charAt(PERMUTATION[i] - 1));
157161
}
158162

159163
return permutedString.toString();
@@ -165,7 +169,8 @@ private String encryptBlock(String message, String[] keys) {
165169
for (i = 0; i < 64; i++) {
166170
permutedMessage.append(message.charAt(IP[i] - 1));
167171
}
168-
String L0 = permutedMessage.substring(0, 32), R0 = permutedMessage.substring(32);
172+
String L0 = permutedMessage.substring(0, 32);
173+
String R0 = permutedMessage.substring(32);
169174

170175
// Iterate 16 times
171176
for (i = 0; i < 16; i++) {
@@ -178,7 +183,7 @@ private String encryptBlock(String message, String[] keys) {
178183
String combinedBlock = R0 + L0; // Reverse the 16th block
179184
permutedMessage.setLength(0);
180185
for (i = 0; i < 64; i++) {
181-
permutedMessage.append(combinedBlock.charAt(IPinverse[i] - 1));
186+
permutedMessage.append(combinedBlock.charAt(IP_INVERSE[i] - 1));
182187
}
183188
return permutedMessage.toString();
184189
}
@@ -198,7 +203,9 @@ private String decryptBlock(String message, String[] keys) {
198203
*/
199204
public String encrypt(String message) {
200205
StringBuilder encryptedMessage = new StringBuilder();
201-
int l = message.length(), i, j;
206+
int l = message.length();
207+
int i;
208+
int j;
202209
if (l % 8 != 0) {
203210
int desiredLength = (l / 8 + 1) * 8;
204211
l = desiredLength;
@@ -223,7 +230,9 @@ public String encrypt(String message) {
223230
*/
224231
public String decrypt(String message) {
225232
StringBuilder decryptedMessage = new StringBuilder();
226-
int l = message.length(), i, j;
233+
int l = message.length();
234+
int i;
235+
int j;
227236
if (l % 64 != 0) {
228237
throw new IllegalArgumentException("Encrypted message should be a multiple of 64 characters in length");
229238
}

‎src/main/java/com/thealgorithms/ciphers/HillCipher.java

+8-3
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ static void encrypt(String message) {
4848
System.out.println(messageVector[i][0]);
4949
j++;
5050
}
51-
int x, i;
51+
int x;
52+
int i;
5253
for (i = 0; i < matrixSize; i++) {
5354
cipherMatrix[i][0] = 0;
5455

@@ -96,7 +97,8 @@ static void decrypt(String message) {
9697
System.out.println(messageVector[i][0]);
9798
j++;
9899
}
99-
int x, i;
100+
int x;
101+
int i;
100102
for (i = 0; i < n; i++) {
101103
plainMatrix[i][0] = 0;
102104

@@ -115,7 +117,10 @@ static void decrypt(String message) {
115117

116118
// Determinant calculator
117119
public static int determinant(int[][] a, int n) {
118-
int det = 0, sign = 1, p = 0, q = 0;
120+
int det = 0;
121+
int sign = 1;
122+
int p = 0;
123+
int q = 0;
119124

120125
if (n == 1) {
121126
det = a[0][0];

‎src/main/java/com/thealgorithms/ciphers/RSA.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public synchronized BigInteger decrypt(BigInteger encryptedMessage) {
4747
/**
4848
* Generate a new public and private key set.
4949
*/
50-
public synchronized void generateKeys(int bits) {
50+
public final synchronized void generateKeys(int bits) {
5151
SecureRandom r = new SecureRandom();
5252
BigInteger p = new BigInteger(bits / 2, 100, r);
5353
BigInteger q = new BigInteger(bits / 2, 100, r);

‎src/main/java/com/thealgorithms/conversions/AnyBaseToAnyBase.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ private AnyBaseToAnyBase() {
2727
public static void main(String[] args) {
2828
Scanner in = new Scanner(System.in);
2929
String n;
30-
int b1, b2;
30+
int b1;
31+
int b2;
3132
while (true) {
3233
try {
3334
System.out.print("Enter number: ");
@@ -132,7 +133,8 @@ public static String base2base(String n, int b1, int b2) {
132133
// Declare variables: decimal value of n,
133134
// character of base b1, character of base b2,
134135
// and the string that will be returned.
135-
int decimalValue = 0, charB2;
136+
int decimalValue = 0;
137+
int charB2;
136138
char charB1;
137139
String output = "";
138140
// Go through every character of n

‎src/main/java/com/thealgorithms/conversions/AnytoAny.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@ public static void main(String[] args) {
1515
int sn = scn.nextInt();
1616
int sb = scn.nextInt();
1717
int db = scn.nextInt();
18-
int m = 1, dec = 0, dn = 0;
18+
int m = 1;
19+
int dec = 0;
20+
int dn = 0;
1921
while (sn != 0) {
2022
dec = dec + (sn % 10) * m;
2123
m *= sb;

‎src/main/java/com/thealgorithms/conversions/BinaryToDecimal.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ private BinaryToDecimal() {
1010
}
1111

1212
public static long binaryToDecimal(long binNum) {
13-
long binCopy, d, s = 0, power = 0;
13+
long binCopy;
14+
long d;
15+
long s = 0;
16+
long power = 0;
1417
binCopy = binNum;
1518
while (binCopy != 0) {
1619
d = binCopy % 10;

‎src/main/java/com/thealgorithms/conversions/BinaryToOctal.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ public static void main(String[] args) {
3232
*/
3333
public static String convertBinaryToOctal(int binary) {
3434
String octal = "";
35-
int currBit = 0, j = 1;
35+
int currBit = 0;
36+
int j = 1;
3637
while (binary != 0) {
3738
int code3 = 0;
3839
for (int i = 0; i < 3; i++) {

‎src/main/java/com/thealgorithms/conversions/DecimalToBinary.java

+8-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ public static void main(String[] args) {
2424
* conventional algorithm.
2525
*/
2626
public static void conventionalConversion() {
27-
int n, b = 0, c = 0, d;
27+
int n;
28+
int b = 0;
29+
int c = 0;
30+
int d;
2831
Scanner input = new Scanner(System.in);
2932
System.out.printf("Conventional conversion.%n Enter the decimal number: ");
3033
n = input.nextInt();
@@ -42,7 +45,10 @@ public static void conventionalConversion() {
4245
* algorithm
4346
*/
4447
public static void bitwiseConversion() {
45-
int n, b = 0, c = 0, d;
48+
int n;
49+
int b = 0;
50+
int c = 0;
51+
int d;
4652
Scanner input = new Scanner(System.in);
4753
System.out.printf("Bitwise conversion.%n Enter the decimal number: ");
4854
n = input.nextInt();

0 commit comments

Comments
 (0)