Skip to content

Added Korean translation #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2023
Merged

Added Korean translation #213

merged 2 commits into from
Jul 3, 2023

Conversation

KANGPUNGYUN
Copy link
Contributor

@KANGPUNGYUN KANGPUNGYUN commented Jul 2, 2023 •
edited
Loading

Description

I translated the explanation of Aliquot Sum function into Korean.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing checks pass.
  • No plagiarized, duplicated, or repetitive documentation that has been directly copied from another source.
  • If it's a new explanation, it contains solid, understandable, and accessible information.
  • I have read the whole contributing guidelines and agree to the Code of Conduct.

appgurueu
appgurueu previously approved these changes Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine (judging by Google Translate). We should probably just link to The Algorithms rather than individual sites.

Panquesito7
Panquesito7 reviewed Jul 3, 2023
View reviewed changes
ko/기초 수학/진약수의 합.md Outdated
- [Java](https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/AliquotSum.java)
- [JavaScript](https://github.com/TheAlgorithms/JavaScript/blob/master/Maths/AliquotSum.js)
- [Python](https://github.com/TheAlgorithms/Python/blob/master/maths/aliquot_sum.py)
- [Ruby](https://github.com/TheAlgorithms/Ruby/blob/master/maths/aliquot_sum.rb)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to link the whole implementation website as well (link here). 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right! Isn't it a link to The Algorithms? I thought this link was The Algorithms link. If it is not The Algorithms site link, can I know the correct link address? Then i'll change the link :)

Copy link
Member

@Panquesito7 Panquesito7 Jul 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the link to its implementation as stated in the contributing guidelines.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to both? Just the link to the "The Algorithms page" of the algorithm (Aliquot Sum) should suffice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited.

@KANGPUNGYUN
Update 진약수의 합.md
0bd308e 
Change the implementation link from individual sites to The Algorithms.
KANGPUNGYUN
KANGPUNGYUN commented Jul 3, 2023
View reviewed changes
Copy link
Contributor Author

@KANGPUNGYUN KANGPUNGYUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read contributing guidelines again. And I checked your latest commit(cycle sort.md) and changed it similarly. Is it OK?

Panquesito7
Panquesito7 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesom. Thanks! 🚀

@Panquesito7 Panquesito7 merged commit afd9db9 into TheAlgorithms:master Jul 3, 2023
@KANGPUNGYUN KANGPUNGYUN changed the title Add Korean translation Added Korean translation Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@vbrazo vbrazo Awaiting requested review from vbrazo vbrazo is a code owner

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KANGPUNGYUN @appgurueu @Panquesito7