Skip to content

Feat: add cycle sort #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2023
Merged

Feat: add cycle sort #212

merged 3 commits into from
May 26, 2023

Conversation

BSzmolke
Copy link
Contributor

@BSzmolke BSzmolke commented May 24, 2023

Description

Add short description of cycle sort algorithm

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing checks pass.
  • No plagiarized, duplicated, or repetitive documentation that has been directly copied from another source.
  • If it's a new explanation, it contains solid, understandable, and accessible information.
  • I have read the whole contributing guidelines and agree to the Code of Conduct.

appgurueu
appgurueu previously approved these changes May 24, 2023
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, minor formatting issues can be fixed later on. Aren't the implementation links redundant with the The Algorithms page?

@BSzmolke
Copy link
Contributor Author

Looks fine, minor formatting issues can be fixed later on. Aren't the implementation links redundant with the The Algorithms page?

@appgurueu I thought it's expected as per line:

7. Further resources such as reference implementations, videos or other explanations. *If possible, link to The Algorithms' website as well (example: <https://the-algorithms.com/algorithm/quick-sort>).*

But I'm happy to remove if you think it would be better without it

@appgurueu
Copy link
Collaborator

Looks fine, minor formatting issues can be fixed later on. Aren't the implementation links redundant with the The Algorithms page?

@appgurueu I thought it's expected as per line:

7. Further resources such as reference implementations, videos or other explanations. *If possible, link to The Algorithms' website as well (example: <https://the-algorithms.com/algorithm/quick-sort>).*

But I'm happy to remove if you think it would be better without it

I think you should remove the direct links to implementations, not the link to The Algorithms.

@BSzmolke
Copy link
Contributor Author

Redundant links removed

appgurueu
appgurueu previously approved these changes May 24, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit c811d73 into TheAlgorithms:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants