Skip to content

use "Sloeber" instead of "Arduino" when we are talking about sloeber stuf #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jantje opened this issue Dec 30, 2021 · 4 comments
Closed

Comments

@jantje
Copy link
Member

jantje commented Dec 30, 2021

There are lot of places Sloeber should use the name "Sloeber" instead of the name "Arduino".
For instance project and preference configuration and perspective should be named Sloeber and not Arduino.
On the other hand the board name and references to the Arduino framework should remain "Arduino"

This is strictly text naming changes (no class names will be changed) but it is important to have a issue as this may become confusing for users to find what they are looking for.

@MiBiMiFlo
Copy link

MiBiMiFlo commented Jan 10, 2022

Is it ok to comment here if I find some places where it still is names Arduino?

First is the tool tip of The Perspective:
grafik

And in Project Properties it still says "Arduino Board Selection"
grafik

And third is in Shortcuts of "Customize Perspective - Sloeber" Category is Arduino:
grafik

The same is in New Project:
grafik

@jantje
Copy link
Member Author

jantje commented Jan 10, 2022

Thanks for the feedback. If you find more please report.

I tested the perspective hover. On my system it states Sloeber. Did you select the sloeber perspective in the list again? If noit it may be remains of the arduino perspective you see.

I think the "Arduino Board Selection" is the right name as you select a arduino board and not a sloeber board.

The rest I fixed.

https://user-images.githubusercontent.com/78593933/148801819-8aa41730-e9ad-4cbb-bfe8-cd008108a1ea.png
I'm not sure about "Arduino sketch" and "convert to sloeber project"
I think it is inconsistent but on the other hand all the things I can think of to make it consistent seem less clear 😕

@MiBiMiFlo
Copy link

You are right, seems I used an old workspace. With a new workspace the tool tip of the perspective is correct now.

@jantje
Copy link
Member Author

jantje commented Feb 16, 2022

I think I changed all needed places.

@jantje jantje closed this as completed Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants