Skip to content

FeatureRequest - Allow to create toolbar buttons for Arduino actions #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MiBiMiFlo opened this issue Nov 17, 2021 · 9 comments
Closed

Comments

@MiBiMiFlo
Copy link

The Action "Upload the sketch using the selected programmer" from Arduino Menu should be available in the Tool Bar as well. This would be great!

@jantje jantje changed the title FeatureRequest - Allow to use "Upload the sketch using the selected programmer" in Tool Bar FeatureRequest - Allow to create toolbar buttons for Arduino actions Nov 17, 2021
@jantje
Copy link
Member

jantje commented Nov 17, 2021

For one reason or another the actions are not visible when in windows->perspective->customize perspective->action set availability
One available there it should be possible to create toolbars/menus to execute the actions.

Note for "upload sketch using the selected programmer"
This action is actually a make target and can as sutch also be started in the project->config folder(normally Release)->targets

@jantje
Copy link
Member

jantje commented Dec 30, 2021

Seems the tooolbar manipulation in eclipse is not working the way I expected.
Therefore I added a extra toolbar that allows you to access nearly all Sloeber menu items. you can hide them via menu:window->perspective->customize perspective

The idea is that this extra toolbar is hidden by default and can be enabled by advanced users.
However I don't get the hidden by default to work.
It seems there is a long lasting bug in eclipse (reported 2013) https://bugs.eclipse.org/bugs/show_bug.cgi?id=400217
This article explains how to work around it
https://jonathanjwright.wordpress.com/2014/07/15/eclipse-4-4-0-perspective-based-show-hide-of-tool-bar-items/
it states
The first problem I encountered was the fact that expressions are not evaluated for items added directly to the main tool bar (see Bug 400217). By ‘added directly’ I mean added as children of the tool bar element in the e4xmi application model. Luckily, when added as ToolBar Contributions visible-when expressions are evaluated as expected.
I fail to understand what this means.
As CDT toolbars get hidden/shown by switching perspective; I checked the CDT code but that leaded to nothing as CDT uses the deprecated action set.

@wimjongman @rlogiacco
Maybe one of you know how to get the toolbar visibility to work. Don't spend to much time one it as one may very rightfully say it is a bad idea to hide this toolbar by default.

PS I also added a show project properties->sloeber button to the Sloeber toolbar in 4311ae4

@wimjongman
Copy link
Member

Seems the tooolbar manipulation in eclipse is not working the way I expected.
Therefore I added a extra toolbar that allows you to access nearly all Sloeber menu items. you can hide them via menu:window->perspective->customize perspective

I don't think an extra toolbar is a good idea. Certainly not for the reasons stated.

I have downloaded the latest code but I don't see the extra toolbar.

What is it exactly that you want to achieve? It goes beyond the initial request of this issue.

The Action "Upload the sketch using the selected programmer" from Arduino Menu should be available in the Tool Bar as well.

@jantje
Copy link
Member

jantje commented Dec 30, 2021

This is what I have in my Sloeber
afbeelding
As you can see I plenty more buttons
afbeelding

@jantje
Copy link
Member

jantje commented Dec 30, 2021

What is it exactly that you want to achieve? It goes beyond the initial request of this issue.

The Action "Upload the sketch using the selected programmer" from Arduino Menu should be available in the Tool Bar as well.

Well I was thinking .... If I add 1 menu item I can just as well add more ...

@wimjongman
Copy link
Member

Ok, this makes sense. I would make it easy and always show the toolbar. Let the user hide it in perspective customization if they don't want it.

@wimjongman
Copy link
Member

May I suggest using branches and pull requests instead of inserting commits directly into the master branch?

@jantje
Copy link
Member

jantje commented Jan 1, 2022

Ok, this makes sense. I would make it easy and always show the toolbar. Let the user hide it in perspective customization if they don't want it.

Ok. I think that is how it is now.

@jantje
Copy link
Member

jantje commented Jan 2, 2022

@MiBiMiFlo
I'm closing this as fixed in the nightly. Please check and reopen if this doesn't suit your needs.

@jantje jantje closed this as completed Jan 2, 2022
jantje pushed a commit that referenced this issue Jan 28, 2022
Also removed the visible when as this doesn't work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants