Move of workaround to installation phase will cause issues #1167
Comments
jantje
pushed a commit
that referenced
this issue
Apr 7, 2020
jantje
pushed a commit
that referenced
this issue
Apr 7, 2020
This fix creates and works with a sloeber variant of boards.txt and platfrom.txt. This way the original files are not touched. This works with previously installed released versions. Nightly gives issues with some boards due to double workarounds. Removing and installing again does the trick The first line in the sloeber variants is used to identify the "workaround version" to enable updates on the fly NOTE: this change also copies the package json file to the platform but is not yet using it. Still need to think how to get this to work safely
|
as this is a inter release issue this does not need to be tagged as fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current nightly works around issues by modifying platform.txt and boards.txt at installation time.
This will cause issues when people upgrade because there is no installation done with the version that works around the known issues.
Moreover the platform.txt is modified (and the original is saved as .org file) where it would be better to add a sloeber.platform.txt.
Adding a sloeber.platform.txt makes it possible to look real time wether workarounds need to be applied
It would also enable not boardsmanager iunstalled platforms to be worked around
It would also enable platform providers to privide their own "sloeber worked around files"
It would also avoid version controlled private hardware to be modified by sloeber
I think this should be done before releasing the workaround change.
Also the json file should be dumped in the platform.
The text was updated successfully, but these errors were encountered: