#1167 tested in windows

This fix creates and works with a sloeber variant of boards.txt and
platfrom.txt.
This way the original files are not touched.
This works with previously installed released versions.
Nightly gives issues with some boards due to double workarounds.
Removing and installing again does the trick
The first line in the sloeber variants is used to identify the
"workaround version" to enable updates on the fly

NOTE: this change also copies the package json file to the platform but is not yet using it. Still need to think how to get this to work safely

Author: jantje

io.sloeber.core/src/io/sloeber/core/api/PackageManager.java

@@ -682,7 +682,7 @@ static private void loadJson(String url, boolean forceDownload) {
 	static private void loadPackage(File jsonFile) {
 		try (Reader reader = new FileReader(jsonFile)) {
 			PackageIndex index = new Gson().fromJson(reader, PackageIndex.class);
-			index.setOwners(null);
+			index.setOwners();
 			index.setJsonFile(jsonFile);
 			packageIndices.add(index);
 		} catch (Exception e) {
@@ -887,7 +887,7 @@ public static void updateGlobalEnvironmentVariables() {
 		for (ArduinoPlatform curPlatform : InternalPackageManager.getInstalledPlatforms()) {
 
 
-				Package pkg = curPlatform.getPackage();
+				Package pkg = curPlatform.getParent();
 				if (pkg != null) {
 					if (Const.ARDUINO.equalsIgnoreCase(pkg.getMaintainer())) { 
 						Helpers.addPlatformFileTools(curPlatform, contribEnv, confDesc, false );

io.sloeber.core/src/io/sloeber/core/managers/ArduinoPlatform.java

@@ -36,24 +36,24 @@ public class ArduinoPlatform {
 	private List<Board> boards;
 	private List<ToolDependency> toolsDependencies;
 
-	private Package pkg;
+	private Package myParent;
 
 	private static final String ID_SEPERATOR = "-"; //$NON-NLS-1$
 
-	void setOwner(Package pkg) {
-		this.pkg = pkg;
-		for (Board board : this.boards) {
+	void setParent(Package parent) {
+		myParent = parent;
+		for (Board board : boards) {
 			board.setOwners(this);
 		}
 		if (this.toolsDependencies != null) {
-			for (ToolDependency toolDep : this.toolsDependencies) {
+			for (ToolDependency toolDep : toolsDependencies) {
 				toolDep.setOwner(this);
 			}
 		}
 	}
 
-	public Package getPackage() {
-		return this.pkg;
+	public Package getParent() {
+		return this.myParent;
 	}
 
 	public String getName() {
@@ -119,7 +119,7 @@ public File getPlatformFile() {
 	}
 
 	public IPath getInstallPath() {
-		IPath stPath = ConfigurationPreferences.getInstallationPathPackages().append(this.pkg.getName())
+		IPath stPath = ConfigurationPreferences.getInstallationPathPackages().append(this.myParent.getName())
 				.append(Const.ARDUINO_HARDWARE_FOLDER_NAME).append(this.architecture).append(this.version);
 		return stPath;
 	}
@@ -167,7 +167,7 @@ public int hashCode() {
 		final int prime = 31;
 		int result = 1;
 		result = prime * result + ((this.name == null) ? 0 : this.name.hashCode());
-		result = prime * result + ((this.pkg == null) ? 0 : this.pkg.hashCode());
+		result = prime * result + ((this.myParent == null) ? 0 : this.myParent.hashCode());
 		result = prime * result + ((this.version == null) ? 0 : this.version.hashCode());
 		return result;
 	}
@@ -186,10 +186,10 @@ public boolean equals(Object obj) {
 				return false;
 		} else if (!this.name.equals(other.name))
 			return false;
-		if (this.pkg == null) {
-			if (other.pkg != null)
+		if (this.myParent == null) {
+			if (other.myParent != null)
 				return false;
-		} else if (!this.pkg.equals(other.pkg))
+		} else if (!this.myParent.equals(other.myParent))
 			return false;
 		if (this.version == null) {
 			if (other.version != null)
@@ -211,11 +211,11 @@ public List<String> getBoardNames() {
 	public String getID() {
 		String ID=new String();
 
-		if (pkg==null) {
+		if (myParent==null) {
 			ID=getInstallPath().toOSString();
 		}
 		else {
-			ID=pkg.getName();
+			ID=myParent.getName();
 		}
 		ID=ID+ID_SEPERATOR+name+ID_SEPERATOR+architecture;
 

io.sloeber.core/src/io/sloeber/core/managers/InternalPackageManager.java

@@ -17,6 +17,8 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.StandardCopyOption;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -123,13 +125,24 @@ public static void startup_Pluging(IProgressMonitor monitor) {
 	static public IStatus downloadAndInstall(ArduinoPlatform platform, boolean forceDownload,
 			IProgressMonitor monitor) {
 
+		
 		MyMultiStatus mstatus = new MyMultiStatus("Failed to install " + platform.getName()); //$NON-NLS-1$
 		mstatus.addErrors(downloadAndInstall(platform.getUrl(), platform.getArchiveFileName(),
 				platform.getInstallPath(), forceDownload, monitor));
 		if (!mstatus.isOK()) {
 			// no use going on installing tools if the boards failed installing
 			return mstatus;
 		}
+		File packageFile=platform.getParent().getParent().getJsonFile();
+		File copyToFile=platform.getInstallPath().append( packageFile.getName()).toFile();
+		try {
+			Files.copy(packageFile.toPath(),
+					copyToFile.toPath(),
+			        StandardCopyOption.REPLACE_EXISTING);
+		} catch (IOException e) {
+			// TODO Auto-generated catch block
+			e.printStackTrace();
+		}
 
 		if (platform.getToolsDependencies() != null) {
 			for (ToolDependency tool : platform.getToolsDependencies()) {

io.sloeber.core/src/io/sloeber/core/managers/Package.java

@@ -25,16 +25,22 @@ public class Package implements Comparable<Package> {
 	private Help help;
 	private List<ArduinoPlatform> platforms;
 	private List<Tool> tools;
+	private PackageIndex myParent=null;
 
-	void setOwner(InternalPackageManager manager) {
+	 public PackageIndex getParent() {
+		 return myParent;
+	 }
+
+	void setParent(PackageIndex parent) {
+		myParent=parent;
 		// it happened that the list contained a null so I remove null platforms
 		this.platforms.remove(null);
 		for (ArduinoPlatform platform : this.platforms) {
-			platform.setOwner(this);
+			platform.setParent(this);
 		}
 		if (this.tools != null) {
 			for (Tool tool : this.tools) {
-				tool.setOwner(this);
+				tool.setParent(this);
 			}
 		}
 	}

io.sloeber.core/src/io/sloeber/core/managers/PackageIndex.java

@@ -35,9 +35,9 @@ public Package getPackage(String packageName) {
 	return null;
     }
 
-    public void setOwners(InternalPackageManager manager) {
+    public void setOwners() {
 	for (Package pkg : this.packages) {
-	    pkg.setOwner(manager);
+	    pkg.setParent(this);
 	}
     }
 

io.sloeber.core/src/io/sloeber/core/managers/Tool.java

@@ -28,7 +28,7 @@ public class Tool {
 
 	private transient Package pkg;
 
-	public void setOwner(Package pkg) {
+	public void setParent(Package pkg) {
 		this.pkg = pkg;
 		for (ToolSystem system : this.systems) {
 			system.setOwner(this);

io.sloeber.core/src/io/sloeber/core/managers/ToolDependency.java

@@ -41,7 +41,7 @@ public String getVersion() {
 	}
 
 	public Tool getTool() {
-		Package pkg = this.platform.getPackage();
+		Package pkg = this.platform.getParent();
 		if (!pkg.getName().equals(this.packager)) {
 			pkg = InternalPackageManager.getPackage(this.packager);
 		}