This repository was archived by the owner on Apr 24, 2020. It is now read-only.
Edits in geom_series.rst #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mtiley
commented
Dec 11, 2019
mtiley
commented
- code repetition reduced
- typos fixed
jstac
reviewed
Dec 12, 2019
source/rst/geom_series.rst
Outdated
| y = calculate_y(i_0, b, g, T, y_init) | ||
| ax2.plot(x, y, label=f"g={g}") | ||
|
|
||
| plots = [ax1, ax2] |
There was a problem hiding this comment.
here and in the next line, you could omit the square brackets and still have the same outcome.
There was a problem hiding this comment.
Thanks -- new commit should have fixed that now.
|
This is very nice @mtiley. Please see my minor comment. |
jstac
reviewed
Dec 12, 2019
source/rst/geom_series.rst
Outdated
| y = calculate_y(i_0, b, g, T, y_init) | ||
| ax2.plot(x, y, label=f"g={g}") | ||
|
|
||
| plots = ax1, ax2 |
jstac
reviewed
Dec 12, 2019
source/rst/geom_series.rst
Outdated
|
|
||
| plots = ax1, ax2 | ||
| param_labels = "Investment", "Government Spending" | ||
| for pair in zip(plots, param_labels): |
There was a problem hiding this comment.
please change pair to ax, param and then drop the next two lines. Inside the loop, please make the appropriate name changes.
|
@mtiley, please add the "ready" label when this is ready for review again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.