Skip to content

Fix Menu Title Capitalization #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2017

Conversation

AndySchneiderDev-zz
Copy link
Contributor

in reference to issue #739

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

package.json Outdated
@@ -111,17 +111,17 @@
},
{
"command": "PowerShell.OpenInISE",
"title": "Open current file in PowerShell ISE",
"title": "Open Current file in PowerShell ISE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't file be capitalized as well? Otherwise, LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot, missed that somehow. How should i fix it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you edit this online or via a local fork? If a fork then Add more commits by pushing to the develop branch on SchneiderAndy/vscode-powershell.

@AndySchneiderDev-zz
Copy link
Contributor Author

Added in fix for File

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkeithhill rkeithhill merged commit 3651ffe into PowerShell:develop May 15, 2017
@rkeithhill
Copy link
Contributor

@AndySchneiderDev Thanks!

@daviwil daviwil added this to the 1.1.0 milestone May 15, 2017
@daviwil
Copy link
Contributor

daviwil commented May 15, 2017

Thanks a lot Andy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants