-
Notifications
You must be signed in to change notification settings - Fork 511
Fix Menu Title Capitalization #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
in reference to issue PowerShell#739
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
package.json
Outdated
@@ -111,17 +111,17 @@ | |||
}, | |||
{ | |||
"command": "PowerShell.OpenInISE", | |||
"title": "Open current file in PowerShell ISE", | |||
"title": "Open Current file in PowerShell ISE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't file
be capitalized as well? Otherwise, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot, missed that somehow. How should i fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you edit this online or via a local fork? If a fork then Add more commits by pushing to the develop branch on SchneiderAndy/vscode-powershell.
Added in fix for File |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AndySchneiderDev Thanks! |
Thanks a lot Andy! |
in reference to issue #739