Skip to content

Capitalization in Menu Titles is Inconsistent #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndySchneiderDev-zz opened this issue May 12, 2017 · 3 comments
Closed

Capitalization in Menu Titles is Inconsistent #739

AndySchneiderDev-zz opened this issue May 12, 2017 · 3 comments
Labels
Issue-Enhancement A feature request (enhancement).
Milestone

Comments

@AndySchneiderDev-zz
Copy link
Contributor

System Details

  • Operating system name and version: Win 10, 1703
  • VS Code version: 1.12.1
  • PowerShell extension version: 1.0.0
  • Output from $PSVersionTable:
Name                           Value
----                           -----
PSVersion                      5.1.15063.168
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15063.168
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

I am experiencing a problem with the capitalization on the menus. When you right click on selected text, you get an option to "Run selection" "selection" should be capitalized to match the rest of the menu

Looking at project.json, it seems like there is quite a bit of inconsistency in the titles of commands.

I would suggest we capitalize all nouns, verbs, adjectives, and lowercase just the articles, pronouns and conjunctions.

As an example, Get online help for command should be Get Online Help for Command and Run selection should be Run Selection

"commands": [
			{
				"command": "PowerShell.ExpandAlias",
				"title": "Expand Alias",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.OnlineHelp",
				"title": "Get online help for command",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.RunSelection",
				"title": "Run selection",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.RestartSession",
				"title": "Restart Current Session",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.ShowLogs",
				"title": "Show PowerShell Extension Logs",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.OpenLogFolder",
				"title": "Open PowerShell Extension Logs Folder",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.OpenInISE",
				"title": "Open current file in PowerShell ISE",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.PowerShellFindModule",
				"title": "Find/Install PowerShell modules from the gallery",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.ShowAdditionalCommands",
				"title": "Show additional commands from PowerShell modules",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.ShowSessionMenu",
				"title": "Show Session Menu",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.SelectPSSARules",
				"title": "Select PSScriptAnalyzer Rules",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.ShowSessionConsole",
				"title": "Show Integrated Console",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.NewProjectFromTemplate",
				"title": "Create New Project from Plaster Template",
				"category": "PowerShell"
			},
			{
				"command": "PowerShell.OpenExamplesFolder",
				"title": "Open Examples Folder",
				"category": "PowerShell"
			}
		],
@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label May 15, 2017
@daviwil daviwil added this to the May 2017 milestone May 15, 2017
@daviwil
Copy link
Contributor

daviwil commented May 15, 2017

This would be a super easy chance to contribute if you're interested :) Otherwise I'll get it fixed soon!

@AndySchneiderDev-zz
Copy link
Contributor Author

I'd be more than happy to, as long as the json file is the only thing that needs editing. I wasn't sure if there were any other files that would be affected.

@daviwil
Copy link
Contributor

daviwil commented May 15, 2017

Nope, just the JSON file. You could do it entirely in GitHub's online editor

AndySchneiderDev-zz added a commit to SchneiderAndy-zz/vscode-powershell that referenced this issue May 15, 2017
AndySchneiderDev-zz added a commit to SchneiderAndy-zz/vscode-powershell that referenced this issue May 15, 2017
rkeithhill pushed a commit that referenced this issue May 15, 2017
* Fix menu title capitalization

in reference to issue #739

* Fixed "File" in title
@daviwil daviwil modified the milestones: 1.1.0, May 2017 May 15, 2017
@daviwil daviwil closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

2 participants