Skip to content

Bump @vscode/extension-telemetry from 0.8.2 to 0.8.3 #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 21, 2023

Bumps @vscode/extension-telemetry from 0.8.2 to 0.8.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> dependency will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> dependency will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot requested a review from a team August 21, 2023 21:37
@andyleejordan
Copy link
Member

Not sure why this was a patch update, per microsoft/vscode-extension-telemetry#172 a new VS Code API is being used which is causing the build to fail (probably requires an engine update).

@andyleejordan
Copy link
Member

FWIW I tried bumping the engine up to 1.79.2 which is what ADS actually pulled in, but still the same issue. Trying to see if they've since updated, and if not, what the minimum VS Code engine is that adds TelemetryTrustedValue.

Bumps [@vscode/extension-telemetry](https://github.com/Microsoft/vscode-extension-telemetry) from 0.8.2 to 0.8.3.
- [Release notes](https://github.com/Microsoft/vscode-extension-telemetry/releases)
- [Commits](microsoft/vscode-extension-telemetry@v0.8.2...v0.8.3)

---
updated-dependencies:
- dependency-name: "@vscode/extension-telemetry"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/vscode/extension-telemetry-0.8.3 branch from 31275a0 to 9c4ff1c Compare August 21, 2023 22:21
@andyleejordan
Copy link
Member

Ok so yeah that update requires VS Code engine 1.81.1 and I just verified that ADS is still on 1.79.2: https://github.com/microsoft/azuredatastudio/blob/60bff01240de7189c1f764c6f7566265a85f3e4e/product.json#L50

Closing until one of the two things is fixed externally...

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 21, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/vscode/extension-telemetry-0.8.3 branch August 21, 2023 22:31
andyleejordan added a commit that referenced this pull request Aug 22, 2023
Which wasn't working in #4709 because our `@types/vscode` package was
out of date, so that was updated too.
github-merge-queue bot pushed a commit that referenced this pull request Aug 22, 2023
Which wasn't working in #4709 because our `@types/vscode` package was
out of date, so that was updated too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant