Skip to content

add new setting to setting terminal startLocation #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

krishnakanumuri
Copy link

PR Summary

This PR introduces a new integrated terminal setting to allow users to choose default start location based on their preference. This new setting allows user to set the Start Location for integrated terminal to either Edior or Panel.

When set to:

  • Editor : Extension terminal starts in VS Code Editor area (current behaviour), this is the default.
  • Panel : Extension terminal starts in VS Code terminal area (new behaviour)

This is realted to issue: #4181

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@krishnakanumuri krishnakanumuri requested a review from a team June 12, 2023 05:43
@krishnakanumuri
Copy link
Author

krishnakanumuri commented Jun 12, 2023

@microsoft-github-policy-service agree

@andyleejordan
Copy link
Member

Oops. Sorry @krishankanumuri I accidentally pushed the wrong commit when editing your PR and closed this which now means I can't push to that branch again. Don't worry about it, I'll re-open a PR with your name on the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants