Skip to content

Set default location for Powershell extension terminal window #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
krishnakanumuri opened this issue Sep 26, 2022 · 13 comments · Fixed by #4639
Closed
2 tasks done

Set default location for Powershell extension terminal window #4181

krishnakanumuri opened this issue Sep 26, 2022 · 13 comments · Fixed by #4639
Labels
Area-Configuration Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@krishnakanumuri
Copy link

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

Currently whenever powershell extensions starts it opens a terminal window in VS Code editor area, I would like a setting to set the default location for terminal windows e.g., in editor area, in Terminal tab.

This will help optimize the workflow where users are configured to open terminal in lower panel instead of in Editor window. Currently It requires manual intervention to move the extension terminal window to lower panel.

Proposed Design

No response

@krishnakanumuri krishnakanumuri added the Issue-Enhancement A feature request (enhancement). label Sep 26, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Sep 26, 2022
@andyleejordan
Copy link
Member

Have you tried just hiding it at startup? Then you can put it (and all the other VS Code terminals) wherever you want using their APIs. It's this setting: powershell.integratedConsole.showOnStartup.

@andyleejordan andyleejordan removed the Needs: Triage Maintainer attention needed! label Sep 27, 2022
@krishnakanumuri
Copy link
Author

Hi @andschwa, seems powershell.integratedConsole.showOnStartup is disabled. I tried enabling this setting, but I see no difference. Whenever Powershell extension is initialized, it starts the terminal in editor area. From the description I understand when showOnStartupsetting is disabled Intergrated powershell terminal window should not be visible and I need to run show terminal command but that doesn't seem to be the case.

Basically, what I am looking for is some sort of setting like powershell.integratedConsole.startupLocation and this setting accepts like Terminal area or in Editor area.

Please let me know if I can provide any further details/logs.

@andyleejordan
Copy link
Member

The showOnStartup setting should be working to hide the terminal on startup, please let me know if that's still the case with the latest version.

@andyleejordan andyleejordan added the Needs: Author Feedback Please give us the requested feedback! label Dec 7, 2022
@ghost ghost closed this as completed Dec 15, 2022
@ghost
Copy link

ghost commented Dec 15, 2022

This issue was closed automatically as author feedback was indicated as needed, but there has been no activity in over a week. Please feel free to reopen with any available information!

@Peter-Schneider
Copy link

I had the same issue. For me the setting "powershell.integratedConsole.startInBackground": true worked.

@ghost
Copy link

ghost commented Apr 7, 2023

Thank you for your comment, but please note that this issue has been closed for over a week. For better visibility, consider opening a new issue with a link to this instead.

@krishnakanumuri
Copy link
Author

I had the same issue. For me the setting "powershell.integratedConsole.startInBackground": true worked.

@Peter-Schneider yes, but I want powershell terminal session to be started in lower panel.

@ghost ghost added Needs: Maintainer Attention Maintainer attention needed! and removed Needs: Author Feedback Please give us the requested feedback! labels May 25, 2023
@ghost ghost reopened this May 25, 2023
@krishnakanumuri
Copy link
Author

The showOnStartup setting should be working to hide the terminal on startup, please let me know if that's still the case with the latest version.

Thanks. I want the terminal to be visible but just start in lower panel not in main workspace.

@andyleejordan
Copy link
Member

Right now the default should be with the panel position set to lower. Once created you can move it around as you wish, but we're not currently exposing any settings for the location of the terminal. We'll think about it though!

@krishnakanumuri
Copy link
Author

Right now the default should be with the panel position set to lower. Once created you can move it around as you wish, but we're not currently exposing any settings for the location of the terminal. We'll think about it though!

Thanks @andschwa, if this is something not planned please close the issue.

@andyleejordan
Copy link
Member

Honestly, it's feasible and not a ton of work. Needs a new contributed setting that would pass through to the terminal creation options, but it's in the VS Code API we're using at least. So I'll mark this as up for grabs.

@andyleejordan andyleejordan added Up for Grabs Will shepherd PRs. and removed Needs: Maintainer Attention Maintainer attention needed! labels Jun 8, 2023
@krishnakanumuri
Copy link
Author

Hi @andschwa, I have created a PR for this issue. Please review and provide feedback.

This is my first time working with VS code extension and typescript, so apologies if my changes do not meet coding standards. But I am happy to update it based on feedback.

@andyleejordan
Copy link
Member

You did great! I'm out at a conference right now but I looked briefly and liked it. When I'm back at work I'll give it a test and review and get it merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Configuration Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants