Skip to content

Use named debug configurations instead of duplicating them #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

andyleejordan
Copy link
Member

Now that we have a record of debug configurations we can fix these TODOs.

@andyleejordan andyleejordan requested a review from a team April 27, 2023 17:19
@andyleejordan andyleejordan enabled auto-merge (squash) April 27, 2023 17:19
Now that we have a record of debug configurations we can fix these TODOs.
Also fix name of the `DebugConfiguration` const export.
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Tech Debt Issues for Tech Debt Days! labels Apr 27, 2023
@andyleejordan andyleejordan merged commit 0f33492 into main Apr 27, 2023
@andyleejordan andyleejordan deleted the andschwa/fix-todos branch April 27, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Tech Debt Issues for Tech Debt Days! Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants