Use named debug configurations instead of duplicating them

Now that we have a record of debug configurations we can fix these TODOs.

Author: andyleejordan

src/features/DebugSession.ts

@@ -150,12 +150,7 @@ export class DebugSessionFeature extends LanguageClientConsumer
         this.handlers = [
             languageClient.onNotification(
                 StartDebuggerNotificationType,
-                // TODO: Use a named debug configuration.
-                () => void debug.startDebugging(undefined, {
-                    request: "launch",
-                    type: "PowerShell",
-                    name: "PowerShell: Interactive Session"
-                })),
+                () => void debug.startDebugging(undefined, defaultDebugConfigurations[DebugConfig.InteractiveSession])),
 
             languageClient.onNotification(
                 StopDebuggerNotificationType,
@@ -401,7 +396,7 @@ export class DebugSessionFeature extends LanguageClientConsumer
             });
 
             // Start a child debug session to attach the dotnet debugger
-            // TODO: Accomodate multi-folder workspaces if the C# code is in a different workspace folder
+            // TODO: Accommodate multi-folder workspaces if the C# code is in a different workspace folder
             await debug.startDebugging(undefined, dotnetAttachConfig, session);
             this.logger.writeVerbose(`Dotnet Attach Debug configuration: ${JSON.stringify(dotnetAttachConfig)}`);
             this.logger.write(`Attached dotnet debugger to process ${pid}`);
@@ -754,4 +749,3 @@ export class PickRunspaceFeature extends LanguageClientConsumer {
         this.waitingForClientToken = undefined;
     }
 }
-

src/features/ExtensionCommands.ts

@@ -12,6 +12,7 @@ import { LanguageClient } from "vscode-languageclient/node";
 import { ILogger } from "../logging";
 import { getSettings, validateCwdSetting } from "../settings";
 import { LanguageClientConsumer } from "../languageClientConsumer";
+import { DebugConfig, defaultDebugConfigurations } from "./DebugSession";
 
 export interface IExtensionCommand {
     name: string;
@@ -187,13 +188,7 @@ export class ExtensionCommandsFeature extends LanguageClientConsumer {
 
             vscode.commands.registerCommand("PowerShell.Debug.Start",
                 async () => {
-                    // TODO: Use a named debug configuration.
-                    await vscode.debug.startDebugging(undefined, {
-                        name: "PowerShell: Launch Current File",
-                        type: "PowerShell",
-                        request: "launch",
-                        script: "${file}",
-                    });
+                    await vscode.debug.startDebugging(undefined, defaultDebugConfigurations[DebugConfig.LaunchCurrentFile]);
                 })
         ];
     }

src/features/ISECompatibility.ts

@@ -32,7 +32,6 @@ export class ISECompatibilityFeature implements vscode.Disposable {
     private _originalSettings: Record<string, boolean | string | undefined> = {};
 
     constructor() {
-        // TODO: This test isn't great.
         const testSetting = ISECompatibilityFeature.settings[ISECompatibilityFeature.settings.length - 1];
         this._iseModeEnabled = vscode.workspace.getConfiguration(testSetting.path).get(testSetting.name) === testSetting.value;
         this._commandRegistrations = [