Skip to content

Fix debugger to start language client when necessary #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

andyleejordan
Copy link
Member

Rather than just throwing an error message. Also don't activate on onDebugInitialConfigurations so that the extension doesn't startup unnecessarily.

Resolves #3266 (and some more yak shaving).

Rather than just throwing an error message. Also don't activate on
`onDebugInitialConfigurations` so that the extension doesn't startup
unnecessarily.
@ghost ghost added Area-Startup Area-UI Issue-Enhancement A feature request (enhancement). labels Aug 11, 2022
@andyleejordan andyleejordan marked this pull request as ready for review August 11, 2022 19:12
@andyleejordan andyleejordan requested a review from a team August 11, 2022 19:12
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 13fa269 into main Aug 11, 2022
@andyleejordan andyleejordan deleted the andschwa/debug-starts-client branch August 11, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Startup Area-UI Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Powershell extension should not be noisy when it activates
2 participants