Skip to content

Powershell extension should not be noisy when it activates #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
connor4312 opened this issue Mar 30, 2021 · 1 comment · Fixed by #4125
Closed

Powershell extension should not be noisy when it activates #3266

connor4312 opened this issue Mar 30, 2021 · 1 comment · Fixed by #4125
Assignees
Labels
Area-Startup Area-UI Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@connor4312
Copy link

connor4312 commented Mar 30, 2021

System Details

  • Operating system: Win 10
  • VS Code version: 1.55 Insiders
  • PowerShell extension: 2021.2.1

If you are running VSCode Insiders, use this expression instead (and paste the result inside the backticks):

System Details Output


### VSCode version: 1.55.0-insider c185983a683d14c396952dd432459097bc7f757f x64

### VSCode extensions:
[email protected]
[email protected]       
[email protected]
[email protected]
[email protected]
[email protected]  
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]  
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

### PSES version: 2.3.0.0

### PowerShell version:

Name                           Value
----                           -----
PSVersion                      7.0.3
PSEdition                      Core
GitCommitId                    7.0.3
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Issue Description

  1. With everything on its default settings, open a new empty folder
  2. Do something that triggers activation. In my case: in Debug view, click create a launch.json file
  3. The powershell extension opens a terminal on activation, which makes the quickpick disappear. It also gives a notification that I don't care about (because I'm not doing anything with powershell at the moment.)

Expected Behaviour

I don't want to be interrupted here. I want to use the powershell on certain projects and it should never get in my way when I don't want it to. In this case I was going to debug a JavaScript project in a project that didn't have any .ps1 files in the workspace/anything that would indicate I wanted to do something with powershell.

It also prompts me with a notification when this happens, which is again also quite annoying. One option would be for me to globally disable the extension and only re-enable it in select workspaces, or dig through the settings to figure out which ones to toggle in order to disable this behavior, but in this case I ended up uninstalling the extension since I do involved powershell work very rarely.

Actual Behaviour

Terminals and notifications pop up.

recording

The gif doesn't capture it, but the configuration quickpick popped up briefly before the powershell terminal opening dismissed it.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Mar 30, 2021
@andyleejordan
Copy link
Member

Thanks for the suggestion! Looks like you have a workaround for now. I agree we can make some improvements on the "noise" here.

@andyleejordan andyleejordan added Area-Startup Area-UI Up for Grabs Will shepherd PRs. Issue-Enhancement A feature request (enhancement). and removed Needs: Triage Maintainer attention needed! labels Apr 23, 2021
@andyleejordan andyleejordan added this to the Consider-vNext milestone Sep 22, 2021
@andyleejordan andyleejordan moved this from Todo to In Progress in American Pharoah Aug 11, 2022
Repository owner moved this from In Progress to Done in American Pharoah Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Startup Area-UI Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants