Skip to content

Remove unused feature commands #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Remove unused feature commands #3592

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
327e641
Remove unused feature commands
CrendKing Sep 28, 2021
cdfb653
Leave empty dispose()
CrendKing Sep 28, 2021
a1c7554
Temporarily disable tslint for empty block
CrendKing Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/features/DebugSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export class DebugSessionFeature extends LanguageClientConsumer
implements DebugConfigurationProvider, vscode.DebugAdapterDescriptorFactory {

private sessionCount: number = 1;
private command: vscode.Disposable;
private tempDebugProcess: PowerShellProcess;
private tempSessionDetails: utils.IEditorServicesSessionDetails;

Expand All @@ -51,10 +50,6 @@ export class DebugSessionFeature extends LanguageClientConsumer
return new vscode.DebugAdapterInlineImplementation(debugAdapter);
}

public dispose() {
this.command.dispose();
}

public setLanguageClient(languageClient: LanguageClient) {
languageClient.onNotification(
StartDebuggerNotificationType,
Expand Down
2 changes: 0 additions & 2 deletions src/features/ShowHelp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export const ShowHelpNotificationType =

export class ShowHelpFeature extends LanguageClientConsumer {
private command: vscode.Disposable;
private deprecatedCommand: vscode.Disposable;

constructor(private log: Logger) {
super();
Expand All @@ -34,7 +33,6 @@ export class ShowHelpFeature extends LanguageClientConsumer {

public dispose() {
this.command.dispose();
this.deprecatedCommand.dispose();
}

}