Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Issue report is #3586. These two commands are unused except a
dispose()
call (I suppose these are the remnants of some historical refactoring?) In the generated js file, the declarations are gone, but the calls todispose()
remain, which causes the extension'sdispose()
to fail.I suppose alternatively we could tweak how js files are generated and not optimize out unused variables, but that could have way more footprint than removing them. However, if these variables are still used in some way, you guy decide how to proceed.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.NA
] PR has testsWIP:
to the beginning of the title and remove the prefix when the PR is ready