Skip to content

Remove unused feature commands #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Remove unused feature commands #3592

merged 3 commits into from
Sep 29, 2021

Conversation

CrendKing
Copy link
Contributor

PR Summary

Issue report is #3586. These two commands are unused except a dispose() call (I suppose these are the remnants of some historical refactoring?) In the generated js file, the declarations are gone, but the calls to dispose() remain, which causes the extension's dispose() to fail.

I suppose alternatively we could tweak how js files are generated and not optimize out unused variables, but that could have way more footprint than removing them. However, if these variables are still used in some way, you guy decide how to proceed.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • [NA] PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@ghost
Copy link

ghost commented Sep 28, 2021

CLA assistant check
All CLA requirements met.

@CrendKing CrendKing mentioned this pull request Sep 28, 2021
4 tasks
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please sign the CLA! I'd love to take this PR today. Thanks so much!

@andyleejordan andyleejordan merged commit 3dc11c1 into PowerShell:master Sep 29, 2021
@andyleejordan
Copy link
Member

Thanks so much @CrendKing!

@andyleejordan andyleejordan linked an issue Sep 29, 2021 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deactivate() fails to execute
2 participants