Skip to content

Fix release build pipeline #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

Fix release build pipeline #3286

merged 1 commit into from
Apr 12, 2021

Conversation

andyleejordan
Copy link
Member

Fixes #3282.

@ghost ghost added Area-Build & Release Issue-Bug A bug to squash. labels Apr 9, 2021
@andyleejordan
Copy link
Member Author

From commit:

A backlog task of removing the findPsesBuild script and associated logic
caused us to end up with a release with the wrong artifacts. The tagged PSES
build was partially succeeded, which the download task then ignored as the
trigger, and instead of failing, fell back to this script which gave it the
latest fully succeeded build.

That PSES build was only partially successful because the "Install PowerShell
Daily" step failed due to a transient network error, and so this was
intentionally ignored as it did not affect the build. Or so we thought.

@andyleejordan andyleejordan force-pushed the andschwa/fix-release-build branch 2 times, most recently from f5b94aa to 7425226 Compare April 9, 2021 21:18
andyleejordan
andyleejordan commented Apr 9, 2021
View reviewed changes
.vsts-ci/templates/release-general.yml
targetType: filePath
filePath: ./vscode-powershell/tools/releaseBuild/setVstsVariables.ps1

# TODO: Remove this when satisfied with added trigger.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjmholt This TODO bit us good.

@andyleejordan andyleejordan mentioned this pull request Apr 9, 2021
Closed
@andyleejordan andyleejordan marked this pull request as ready for review April 9, 2021 22:17
@andyleejordan
Copy link
Member Author

Ok so the next preview still has the incorrect version field in the PSD1 file, but that's bug PowerShell/PowerShellEditorServices#1455, I confirmed the DLLs are correct and double-checked the build IDs that were included by the pipeline:

> monodis --assembly ./Microsoft.PowerShell.EditorServices.dll

Assembly Table
Name:          Microsoft.PowerShell.EditorServices
Hash Algoritm: 0x00008004
Version:       2.4.0.0

@andyleejordan andyleejordan force-pushed the andschwa/fix-release-build branch 2 times, most recently from db09af9 to 6a025b2 Compare April 9, 2021 23:33
@andyleejordan andyleejordan requested a review from rjmholt April 9, 2021 23:33
@andyleejordan
Copy link
Member Author

@rjmholt I pulled the version bump out, I'd like to just merge this, and then do the release.

@andyleejordan andyleejordan force-pushed the andschwa/fix-release-build branch from 6a025b2 to d74fe49 Compare April 12, 2021 18:39
@andyleejordan andyleejordan changed the title Fix release build Fix release build pipeline Apr 12, 2021
@andyleejordan
Fix release build pipeline
30ef07d 
A backlog task of removing the `findPsesBuild` script and associated logic
caused us to end up with a release with the wrong artifacts. The tagged PSES
build was partially succeeded, which the download task then ignored as the
trigger, and instead of failing, fell back to this script which gave it the
latest fully succeeded build (an old version of PSES).

That PSES build was only partially successful because the "Install PowerShell
Daily" step failed due to a transient network error, and so this was
intentionally ignored as it did not affect the build. Or so we thought.
@andyleejordan andyleejordan force-pushed the andschwa/fix-release-build branch from d74fe49 to 30ef07d Compare April 12, 2021 18:42
@andyleejordan andyleejordan enabled auto-merge April 12, 2021 18:45
@andyleejordan andyleejordan merged commit 17a48e7 into master Apr 12, 2021
@andyleejordan andyleejordan deleted the andschwa/fix-release-build branch April 12, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

Assignees
No one assigned
Labels
Area-Build & Release Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2021.4.1-preview Includes an old version of PowerShell Editor Services
2 participants
@andyleejordan @rjmholt