Skip to content

Use Git submodule for PowerShellEditorServices dependency #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyleejordan opened this issue Apr 9, 2021 · 3 comments
Closed

Use Git submodule for PowerShellEditorServices dependency #3287

andyleejordan opened this issue Apr 9, 2021 · 3 comments
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement). Resolution-Fixed Will close automatically.

Comments

@andyleejordan
Copy link
Member

PR #3286 has convinced me we need a better solution to bundling our PowerShellEditorServices dependency, because the current approach of relying on an ADO pipeline to download the correct bits isn't great (obviously). It also makes it next to impossible to reliably determine from the Git sources of the extension which version of the LSP server it's meant to interact with.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Build & Release labels Apr 9, 2021
@andyleejordan andyleejordan added this to the Consider-vNext milestone Apr 9, 2021
@andyleejordan
Copy link
Member Author

FYI @rjmholt

@andyleejordan
Copy link
Member Author

Sure, you can check the changelog, but that means we (humans) have to get it right, and there's no real way to automate testing of this because there's nothing in this extension which actually states which version of the dependency it uses. Issue #3282 could really only have been avoided by another manual check (which I'm adding to my release process notes, but still).

@andyleejordan
Copy link
Member Author

andyleejordan commented Jul 28, 2021

So I believe that I've essentially resolved this but without resorting to submodules, with two things:

PowerShell/PowerShellEditorServices#1476 ensures that given a build of PSES, we know exactly which commit it came from, and this is available to the extension too (indeed, it's printed at startup!):

== Build Details ==
- Editor Services version: 2.4.6
- Build origin:            Release
- Build commit:            e03e50547b2c90820e94b18bace2229e54d917f0
- Build time:              7/14/2021 4:46:01 PM

And a987d4d ensures that given a CI/CD run of the extension, we also know (very easily) which commit of PSES was picked up (in the case of CI) or which build of PSES was picked up (in the case of CD), all available under the run's consumed artifacts:

Screen Shot 2021-07-28 at 4 53 00 PM

image

@andyleejordan andyleejordan added the Resolution-Fixed Will close automatically. label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement). Resolution-Fixed Will close automatically.
Projects
None yet
Development

No branches or pull requests

1 participant