Fix migration of codeFormatting.addWhitespaceAroundPipe setting
#2863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
rjmholt
approved these changes
Aug 5, 2020
bergmeister
reviewed
Aug 5, 2020
There was a problem hiding this comment.
Sorry, I was quite busy the last days, thanks for fixing it. You're right with this PR, I should've used the ConfigurationTarget of the old setting as a target for the new one. When I was testing it, the debug instance of VS-Code did not have a workspace open with .vscode folder, hence why I did not notice this when testing.
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #2842
This will properly migrate
codeFormatting.whitespaceAroundPipetocodeFormatting.addWhitespaceAroundPipe.Also, the saving of file triggered the
this.languageClientto cause a warning to show because PSES wasn't finished initializing so I've just swapped the conditional now. Later I could do something different (like athis.isLanguageClientConnectedbut I'll defer that)PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready