Fix migration of codeFormatting.addWhitespaceAroundPipe setting (#2863)

Author: TylerLeonhardt

src/features/RemoteFiles.ts

@@ -38,7 +38,7 @@ export class RemoteFilesFeature extends LanguageClientConsumer {
         this.closeRemoteFiles();
 
         vscode.workspace.onDidSaveTextDocument((doc) => {
-            if (this.languageClient && this.isDocumentRemote(doc)) {
+            if (this.isDocumentRemote(doc) && this.languageClient) {
                 this.languageClient.sendNotification(
                     DidSaveTextDocumentNotificationType,
                     {

src/session.ts

@@ -332,11 +332,11 @@ export class SessionManager implements Middleware {
         const deprecatedSetting = 'codeFormatting.whitespaceAroundPipe'
         const newSetting = 'codeFormatting.addWhitespaceAroundPipe'
         const configurationTargetOfNewSetting = await Settings.getEffectiveConfigurationTarget(newSetting);
-        if (configuration.has(deprecatedSetting) && configurationTargetOfNewSetting === null) {
-            const configurationTarget = await Settings.getEffectiveConfigurationTarget(deprecatedSetting);
-            const value = configuration.get(deprecatedSetting, configurationTarget)
-            await Settings.change(newSetting, value, configurationTarget);
-            await Settings.change(deprecatedSetting, undefined, configurationTarget);
+        const configurationTargetOfOldSetting = await Settings.getEffectiveConfigurationTarget(deprecatedSetting);
+        if (configurationTargetOfOldSetting !== null && configurationTargetOfNewSetting === null) {
+            const value = configuration.get(deprecatedSetting, configurationTargetOfOldSetting)
+            await Settings.change(newSetting, value, configurationTargetOfOldSetting);
+            await Settings.change(deprecatedSetting, undefined, configurationTargetOfOldSetting);
         }
     }
 

test/settings.test.ts

@@ -3,7 +3,7 @@
  *--------------------------------------------------------*/
 
 import * as assert from "assert";
-import { IPowerShellExeDetails } from "../src/platform";
+import * as vscode from "vscode";
 import Settings = require("../src/settings");
 
 suite("Settings module", () => {
@@ -34,4 +34,14 @@ suite("Settings module", () => {
         await Settings.change("powerShellAdditionalExePaths", psExeDetails, true);
         assert.strictEqual(Settings.load().powerShellAdditionalExePaths[0].versionName, psExeDetails[0].versionName);
     });
+
+    test("Can get effective configuration target", async () => {
+        await Settings.change("helpCompletion", "LineComment", false);
+        let target = await Settings.getEffectiveConfigurationTarget("helpCompletion");
+        assert.strictEqual(target, vscode.ConfigurationTarget.Workspace);
+
+        await Settings.change("helpCompletion", undefined, false);
+        target = await Settings.getEffectiveConfigurationTarget("helpCompletion");
+        assert.strictEqual(target, null);
+    });
 });