Per VSCode team request, move vscode to devDependencies

[rkeithhill]

Closes #1604

PR Summary

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

• PR has a meaningful title
• Summarized changes
• PR has tests
• This PR is ready to merge and is not work in progress
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

[rjmholt]

LGTM!

I assume our versions are still up to date?

[rkeithhill]

@TylerLeonhardt @rjmholt What do you think about this one? Merge it?

[TylerLeonhardt]

Sorry I meant to call out to try removing your node_modules and doing:

npm install --production

docs

then try running the extension. This will tell us if we're relying on what should be a dev dependency in our code.

[rkeithhill]

Hmm, npm install --production fails on my machine. Not a great sign but wouldn't the builds catch such a problem?

[TylerLeonhardt]

Looks like we run regular npm install which means devDependencies have been shipping with the extension for probably ever. 😥

https://github.com/PowerShell/vscode-powershell/blob/master/vscode-powershell.build.ps1#L69

[alexdima]

@TylerLeonhardt If you are publishing using vsce, that is smart enough to only package production dependencies.

[TylerLeonhardt]

Good to know! In that case, @rkeithhill can you test the VSIX that CI generated to make sure it still works?

[rkeithhill]

Yes, I'll test it tonight.

[rkeithhill]

Um yeah … wow! AFAICT with some basic smoke testing (code analysis & debugging) the extension works and this change takes us from an installed size of 62.1 MB to 12.9 MB. And the VSIX size goes from 7 MB to 3.5 MB.

@alexandrudima good call. Thanks!

[TylerLeonhardt]

That's amazing!!