Skip to content

Please do not use vscode in the dependencies section of package.json #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexdima opened this issue Nov 8, 2018 · 3 comments · Fixed by #1608
Closed

Please do not use vscode in the dependencies section of package.json #1604

alexdima opened this issue Nov 8, 2018 · 3 comments · Fixed by #1608
Assignees
Labels
Issue-Enhancement A feature request (enhancement).

Comments

@alexdima
Copy link

alexdima commented Nov 8, 2018

The vscode npm module contains some helper stuff which can download vscode for testing purposes if you use continuous integration, which can download the vscode.d.ts, but which also drags in a lot of dependencies. The engines field is the place which captures that this is a vscode extension and it is enforced at runtime.

Using vscode in the dependencies section leads to a lot larger extension size (for no good reason).

The correct place to put it is in devDependencies.

@rkeithhill
Copy link
Contributor

Thanks for letting us know. We'll make that switch.

@rkeithhill
Copy link
Contributor

@alexandrudima Do you guys happen to have an extension that acts as a "linter" for VSCode extensions?

@alexdima
Copy link
Author

alexdima commented Nov 19, 2018

Actually we do and it's bundled with VS Code -- https://github.com/Microsoft/vscode/tree/master/extensions/extension-editing -- we could perhaps catch this automatically at development time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants