Skip to content

Migrate VSCode to using EditorServices as a standalone, and building that way #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2018
Merged

Migrate VSCode to using EditorServices as a standalone, and building that way #1252

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a9f68a
Change Start-PSES path to use PSES' own script
rjmholt Mar 29, 2018
aa9ee8b
Delete VS code start PSES script
rjmholt Mar 29, 2018
891bca8
Change build to use PSES build file, change over PSES asset paths
rjmholt Mar 31, 2018
19f6249
Update start script location
rjmholt Apr 19, 2018
deec351
Fix path
rjmholt Apr 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions modules.json
View file
Open in desktop

This file was deleted.

353 changes: 0 additions & 353 deletions scripts/Start-EditorServices.ps1
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion src/process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export class PowerShellProcess {

constructor(
public exePath: string,
private bundledModulesPath: string,
private title: string,
private log: Logger,
private startArgs: string,
Expand All @@ -40,7 +41,8 @@ export class PowerShellProcess {
const startScriptPath =
path.resolve(
__dirname,
"../../scripts/Start-EditorServices.ps1");
this.bundledModulesPath,
"../scripts/Start-EditorServices.ps1");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I thought we were just going to leave this to what it was before and then have the build script copy the Start-EditorServices.ps1 and move it under ../../..scripts/Start-EditorServices.ps1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change moves it under:

modules/scripts/Start-EditorServices.ps1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugger shows the runtime value set here to be "C:\Users\roholt\Documents\Dev\PowerShellEditorServices\scripts\Start-EditorServices.ps1" on my machine.

I've got it running against PSES #647.

But could be a fluke. Wanna check it works for you too?


const editorServicesLogPath = this.log.getLogFilePath(logFileName);

Expand Down
Loading