Migrate VSCode to using EditorServices as a standalone, and building that way #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/process.ts
Outdated
| @@ -40,7 +41,8 @@ export class PowerShellProcess { | |||
| const startScriptPath = | |||
| path.resolve( | |||
| __dirname, | |||
| "../../scripts/Start-EditorServices.ps1"); | |||
| this.bundledModulesPath, | |||
| "../scripts/Start-EditorServices.ps1"); | |||
There was a problem hiding this comment.
So I thought we were just going to leave this to what it was before and then have the build script copy the Start-EditorServices.ps1 and move it under ../../..scripts/Start-EditorServices.ps1
There was a problem hiding this comment.
this change moves it under:
modules/scripts/Start-EditorServices.ps1
There was a problem hiding this comment.
Debugger shows the runtime value set here to be "C:\Users\roholt\Documents\Dev\PowerShellEditorServices\scripts\Start-EditorServices.ps1" on my machine.
I've got it running against PSES #647.
But could be a fluke. Wanna check it works for you too?
This was referenced Apr 4, 2018
TylerLeonhardt
approved these changes
Apr 5, 2018
|
We just need to make sure we merge in the PSES one first 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined with PSES #647, this moves all the building and starting of EditorServices into EditorServices and out of the VSCode extension. Because I changed a bunch of paths, I've tried to make them all as configurable and single-set as possible, but I'm pretty sure there's more work to do here. Just need more eyes at the moment.