Skip to content

PS> being added to custom prompts for some users #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue May 31, 2017 · 0 comments · Fixed by PowerShell/PowerShellEditorServices#479
Closed

PS> being added to custom prompts for some users #808

daviwil opened this issue May 31, 2017 · 0 comments · Fixed by PowerShell/PowerShellEditorServices#479
Labels
Area-Extension Terminal Issue-Bug A bug to squash.
Milestone
1.2.1

Comments

@daviwil
Copy link
Contributor

daviwil commented May 31, 2017

Some users with custom prompt functions have reported that an extra PS> is being printed out after their custom prompt function runs. This seems to be related to the return value of the function but I haven't been able to reproduce it yet. Investigating...
@daviwil daviwil added this to the 1.2.1 milestone May 31, 2017
daviwil added a commit to daviwil/PowerShellEditorServices that referenced this issue May 31, 2017
@daviwil
Fix evaluation of prompt function output to remove unneeded "PS>"
2e2b31b 
This change fixes an issue in the integrated console where the result of
a user's custom prompt function would not be interpreted correctly,
causing the default prompt string of "PS>" to be written out when it
wasn't needed.  The fix is to expect a PSObject result rather than
object so that we can evaluate the inner object's type correctly.

Resolves PowerShell/vscode-powershell#808.
@daviwil daviwil mentioned this issue May 31, 2017
Merged
daviwil added a commit to PowerShell/PowerShellEditorServices that referenced this issue May 31, 2017
@daviwil
Fix evaluation of prompt function output to remove unneeded "PS>"
c03b7fb 
This change fixes an issue in the integrated console where the result of
a user's custom prompt function would not be interpreted correctly,
causing the default prompt string of "PS>" to be written out when it
wasn't needed.  The fix is to expect a PSObject result rather than
object so that we can evaluate the inner object's type correctly.

Resolves PowerShell/vscode-powershell#808.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Extension Terminal Issue-Bug A bug to squash.
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

Fix evaluation of prompt function output to remove unneeded "PS>" daviwil/PowerShellEditorServices
1 participant
@daviwil