Fix evaluation of prompt function output to remove unneeded "PS>" #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue in the integrated console where the result of a user's custom prompt function would not be interpreted correctly, causing the default prompt string of "PS>" to be written out when it wasn't needed. The fix is to expect a PSObject result rather than object so that we can evaluate the inner object's type correctly. Resolves PowerShell/vscode-powershell#808.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue in the integrated console where the result of
a user's custom prompt function would not be interpreted correctly,
causing the default prompt string of "PS>" to be written out when it
wasn't needed. The fix is to expect a PSObject result rather than
object so that we can evaluate the inner object's type correctly.
Resolves PowerShell/vscode-powershell#808.