Skip to content

Add the ability to customize Session Status color #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Mar 5, 2019 · 12 comments · Fixed by #3531
Closed

Add the ability to customize Session Status color #1779

ghost opened this issue Mar 5, 2019 · 12 comments · Fixed by #3531
Assignees
Labels
Area-UI Issue-Enhancement A feature request (enhancement).

Comments

@ghost
Copy link

ghost commented Mar 5, 2019

Summary of the new feature

Currently the colors of session statuses are almost invisible when you are using a light color theme

        let statusIconText = "$(terminal) ";
        let statusColor = "#affc74";

        if (status === SessionStatus.Initializing) {
            statusIconText = "$(sync) ";
            statusColor = "#f3fc74";
        } else if (status === SessionStatus.Failed) {
            statusIconText = "$(alert) ";
            statusColor = "#fcc174";
        }
@SydneyhSmith SydneyhSmith added Issue-Enhancement A feature request (enhancement). Feature: VS Code Request to use or implement a VS Code feature. Triage labels Mar 5, 2019
@SydneyhSmith
Copy link
Collaborator

@ihodev thanks for opening this issue--would you mind attaching a screen shot of the session status so we can better understand the problem--Thanks!

@rjmholt
Copy link
Contributor

rjmholt commented Mar 6, 2019

@TylerLeonhardt may have more experience in this area

@ghost
Copy link
Author

ghost commented Mar 6, 2019

would you mind attaching a screen shot of the session status

Yes, of course. Here it is

record_190306_103154

@SydneyhSmith
Copy link
Collaborator

Thanks @ihodev that is very difficult to read!

@SydneyhSmith
Copy link
Collaborator

@ihodev if we made this an easier color to read rather than make it customizable would that be satisfactory?

@ghost
Copy link
Author

ghost commented Mar 13, 2019

@SydneyhSmith I think if colors will have approximately the same lightness as a default status bar foreground color that will be ok.

@SydneyhSmith SydneyhSmith added Triage Area-UI and removed Triage Feature: VS Code Request to use or implement a VS Code feature. labels Mar 13, 2019
@miguelsolorio
Copy link

I'd also like to add that the status bar items shouldn't explicitly set a color as that will cause accessibility issues with color contrast. There are also so many variables with themes that it will be impossible to find a single color that will work across all themes. See below for another example of how this is unreadable:

image

image

As someone who was several extensions that contribute to the status bar, I wouldn't want one extension to be highlighted more than others. I think what would work here is to remove statusColor and request a color token from the VS Code team so that theme authors can properly theme those items.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Sep 20, 2019
@TylerLeonhardt
Copy link
Member

request a color token from the VS Code team so that theme authors can properly theme those items

@misolori isn't there a way to get theme colors from within an extension? Are you saying there's no option for specifically the status bar?

@miguelsolorio
Copy link

@TylerLeonhardt there is currently no way to use theme colors in the status bar from an extension. I think this should be requested for VS Code to support so that extensions don't have to hard code hex colors.

@rkeithhill
Copy link
Contributor

For now, maybe the extension should provide both fg & bg colors for the best contrast. Although that means that part of the status bar may not look good in all color schemes but at least it would be readable. :-)

@TylerLeonhardt
Copy link
Member

opened an issue on VS Code here microsoft/vscode#81401

@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Sep 24, 2019
@TylerLeonhardt
Copy link
Member

Looks like we can add a color to the package.json and leverage that in our code somehow.

https://code.visualstudio.com/api/references/contribution-points#contributes.colors

Seems pretty straightforward.

@andyleejordan andyleejordan added this to the Committed-vNext milestone Aug 26, 2021
@andyleejordan andyleejordan self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants