-
Notifications
You must be signed in to change notification settings - Fork 511
Add the ability to customize Session Status color #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ihodev thanks for opening this issue--would you mind attaching a screen shot of the session status so we can better understand the problem--Thanks! |
@TylerLeonhardt may have more experience in this area |
Thanks @ihodev that is very difficult to read! |
@ihodev if we made this an easier color to read rather than make it customizable would that be satisfactory? |
@SydneyhSmith I think if colors will have approximately the same lightness as a default status bar foreground color that will be ok. |
I'd also like to add that the status bar items shouldn't explicitly set a color as that will cause accessibility issues with color contrast. There are also so many variables with themes that it will be impossible to find a single color that will work across all themes. See below for another example of how this is unreadable: As someone who was several extensions that contribute to the status bar, I wouldn't want one extension to be highlighted more than others. I think what would work here is to remove |
@misolori isn't there a way to get theme colors from within an extension? Are you saying there's no option for specifically the status bar? |
@TylerLeonhardt there is currently no way to use theme colors in the status bar from an extension. I think this should be requested for VS Code to support so that extensions don't have to hard code hex colors. |
For now, maybe the extension should provide both fg & bg colors for the best contrast. Although that means that part of the status bar may not look good in all color schemes but at least it would be readable. :-) |
opened an issue on VS Code here microsoft/vscode#81401 |
Looks like we can add a color to the package.json and leverage that in our code somehow. https://code.visualstudio.com/api/references/contribution-points#contributes.colors Seems pretty straightforward. |
Summary of the new feature
Currently the colors of session statuses are almost invisible when you are using a light color theme
The text was updated successfully, but these errors were encountered: