Skip to content

Status bar items have bad contrast #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miguelsolorio opened this issue Sep 18, 2019 · 2 comments
Closed

Status bar items have bad contrast #2188

miguelsolorio opened this issue Sep 18, 2019 · 2 comments
Labels
Area-UI Issue-Bug A bug to squash. Resolution-Duplicate Will close automatically.

Comments

@miguelsolorio
Copy link

Issue Description

I am experiencing a problem with the status bar item because the color used does not have enough contrast.

Expected Behaviour

A status bar item that is readable on all themes

Actual Behaviour

The status bar item is explicitly settings color that isn't a color token, which means it's going to look bad on other themes because it isn't themeable:

image

image

Code reference:

// Set color and icon for 'Running' by default
let statusIconText = "$(terminal) ";
let statusColor = "#affc74";
if (status === SessionStatus.Initializing) {
statusIconText = "$(sync) ";
statusColor = "#f3fc74";
} else if (status === SessionStatus.Failed) {
statusIconText = "$(alert) ";
statusColor = "#fcc174";
}
this.sessionStatus = status;
this.statusBarItem.color = statusColor;
this.statusBarItem.text = statusIconText + statusText;

@SydneyhSmith
Copy link
Collaborator

@misolori thanks for opening this issue, I am going to mark this as a duplicate of #1779 but please let me know if you do not believe this to be the same issue, thanks!

@SydneyhSmith SydneyhSmith added Area-UI Issue-Bug A bug to squash. Resolution-Duplicate Will close automatically. and removed Needs: Triage Maintainer attention needed! labels Sep 20, 2019
@miguelsolorio
Copy link
Author

@SydneyhSmith that will work, I'll leave a comment there. Thanks!

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Sep 20, 2019
@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Bug A bug to squash. Resolution-Duplicate Will close automatically.
Projects
None yet
Development

No branches or pull requests

3 participants