[UI] Status bar coloring of Session indicator is unreadable for accessibility

[wsmelton]

System Details

System Details Output

### VSCode version: 1.52.0-insider bc13785d3dd99b4b0e9da9aed17bb79809a50804 x64

### VSCode extensions:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]


### PSES version:

### PowerShell version:

Name                           Value
----                           -----
PSVersion                      5.1.19041.610
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.610
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

The status bar indicator color for the session indicator, where it shows the PowerShell version, is not readable in all themes due to the color hardcoded. This should be overwritable using the "statusBar.foreground" setting for workbench.colorCustomizations but the extension is not allowing it.

Expected Behaviour

The color chosen when customizing Themes is honored.

Actual Behaviour

The setting is being ignored as the coloring of that value is hardcoded (it seems) in the extension because it keeps the same color no matter what theme is used.

[corbob]

I believe there's a previous (perhaps closed) issue for this... IIRC there was talk of getting the color from the theme, but that wasn't available or something. Perhaps even if there isn't a way to derive the color from extension, until there is the color should be set as the foreground (ie: remove any custom coloring).

[wsmelton]

If it was made a configurable item would be nice if there is an insistent in having it be a set color.

[ninmonkey]

@corbob I believe this is new functionality that can allow users to customize the color

https://code.visualstudio.com/api/references/contribution-points#contributes.colors

[rjmholt]

In term of the issue as described in the title, I think this is a duplicate of #2436.

Configuration of the colour is discussed in #1779.

[wsmelton]

I tried searching for status bar and such but never came across those two for some reason.

I'll close this since #1779 addresses my concerns.