WIP: Test cherry picks #882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prep 1.11 release with Changelog * spaces
…owerShell#866) The 7 exceptions that are caught now are doc'd in: https://docs.microsoft.com/en-us/dotnet/api/system.io.filestream.-ctor?view=netframework-4.7.2#System_IO_FileStream__ctor_System_String_System_IO_FileMode_System_IO_FileAccess_
* Added `AsNewFile` switch, plus, if a file is not open, it creates a new one * Update module/PowerShellEditorServices/Commands/Public/Out-CurrentFile.ps1 Co-Authored-By: dfinke <[email protected]>
* Return the start line number for Describe block Supports PR 1776 in vscode-powershell * Null check pesterSymbol.ScriptRegion * Update comment to cause new build to kick off * Whitespace change to kick off a new build
* Add attach to local runspace. * Remove comment. * Use single runspaceId property. * Remove unnecessary processId check. * Factored if. * Update src/PowerShellEditorServices.Protocol/Server/DebugAdapter.cs It's neat that we can just commit a suggestion. Co-Authored-By: adamdriscoll <[email protected]> * Use runspace rather than dynamic. * Accept process ID for GetRunspaceRequest. * Clean up.
TylerLeonhardt
requested review from
rjmholt,
rkeithhill and
SeeminglyScience
as code owners
rkeithhill
reviewed
Mar 18, 2019
| @@ -12,7 +12,7 @@ | |||
| RootModule = 'PowerShellEditorServices.psm1' | |||
|
|
|||
| # Version number of this module. | |||
| ModuleVersion = '1.10.3' | |||
| ModuleVersion = '1.11.0' | |||
There was a problem hiding this comment.
This will get bumped to 1.11.1 before the release, right?
There was a problem hiding this comment.
Yeah it will be 1.12.0 because weve got features!
rkeithhill
approved these changes
Mar 18, 2019
|
Yeah this will be closed and I will do it to the branch directly so we keep the full history. |
|
this should go into legacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am waiting on #881 to be merged in before merging this in.
This should probably go in before #880