Handle arbitrary exceptions when recursing workspace #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
requested review from
TylerLeonhardt,
SeeminglyScience and
rkeithhill
rkeithhill
reviewed
Jan 23, 2019
|
Is this going to make it into 1.11.0? |
Unfortunately no (I think that's just been published). But I'm sure we'll have a 1.11.1 |
TylerLeonhardt
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
LGTM. Ideally it'd be cool to move to https://github.com/mganss/Glob.cs but this is fine in the meantime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#1704 (not the original issue, but that's tracked elsewhere).
This should also go into
legacy/1.x