Skip to content

Fix issue w/Auto variables empty in script scope. #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2017

Conversation

rkeithhill
Copy link
Contributor

@rkeithhill rkeithhill commented Mar 26, 2017

This doesn't fix the issue with all the global variables appearing in Auto.

Fixes PowerShell/vscode-powershell#614.

@daviwil
Copy link
Contributor

daviwil commented Mar 28, 2017

Since we're going to keep the current globals-in-auto behavior when the script is dot-sourced, can we consider this PR done? We can do the launch config option in a separate PR.

@rkeithhill
Copy link
Contributor Author

Yes. I still can't believe I had the bit | vs bit & error. Sheesh.

@daviwil
Copy link
Contributor

daviwil commented Mar 28, 2017

Hah! It happens :)

@daviwil daviwil merged commit a003902 into develop Mar 28, 2017
@daviwil daviwil deleted the rkeithhill/fix-auto-variables branch March 28, 2017 00:46
@daviwil daviwil added this to the 0.12.0 milestone Apr 4, 2017
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this pull request Feb 26, 2019
Fix PowerShell#401: Session startup should indicate if PS version is unsupported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants