A few improvements to the interactive debugging experience #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes a message to be displayed in VS Code's Debug Console if the user tries to execute a command there while debugging a PowerShell script. The message directs the user to open the Integrated Console instead. Resolves PowerShell/vscode-powershell#596.
This change causes scripts executed in the debugger to be dot-sourced into the shared session so that the functions defined in the script can be experimented with after debugging is complete. Resolves PowerShell/vscode-powershell#540.
This change enables debugger commands in the integrated console by acting on the DebuggerResumeAction that is returned by the debugger when a command gets executed. If a DebuggerResumeAction is returned, it is used to resume the debugger in whatever way the user requested by typing a command. Resolves PowerShell/vscode-powershell#600.
daviwil
force-pushed
the
debugger-polish
branch
from
50b8754 to
28617c6
Compare
|
Nice enhancements! |
|
Yep, this will be a nice little mini-release :) |
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
…unsupported This change adds some extra logic to Start-EditorServices.ps1 and the SessionManager class to properly report to the user if their PowerShell version is unsupported (PowerShell v2 or below).
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Fix PowerShell#401: Session startup should indicate if PS version is unsupported
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
…error This change improves a previous fix where we report an unsupported PowerShell version when the user attempts to start the extension. The previous fix utilized ConvertTo-Json to write out the session details; this caused a failure since this cmdlet was introduced in PowerShell v3. We now write out teh JSON manually in this case.
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.