Skip to content

Declare scope prefixes array as static readonly #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Declare scope prefixes array as static readonly #1991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/PowerShellEditorServices/Utility/VisitorUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,18 @@ internal static class VisitorUtils
return PSESSymbols.AstOperations.TryGetInferredValue(expandableStringExpressionAst, out string value) ? value : null;
}

private static readonly string[] s_scopes = new string[]
{
"private:",
"script:",
"global:",
"local:"
};

// Strip the qualification, if there is any, so script:my-function is a reference of my-function etc.
internal static string GetUnqualifiedFunctionName(string name)
{
foreach (string scope in new string[] { "private:", "script:", "global:", "local:" })
foreach (string scope in s_scopes)
{
if (name.StartsWith(scope, StringComparison.OrdinalIgnoreCase))
{
Expand Down