Skip to content

Declare scope prefixes array as static readonly #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2023
Merged

Declare scope prefixes array as static readonly #1991

merged 1 commit into from
Feb 11, 2023

Conversation

andyleejordan
Copy link
Member

I forgot that C# won't just optimize away static arrays.

@andyleejordan andyleejordan added the Ignore Exclude from the changelog. label Feb 8, 2023
@andyleejordan andyleejordan requested a review from a team February 8, 2023 23:32
SeeminglyScience
SeeminglyScience approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan added this pull request to the merge queue Feb 9, 2023
@andyleejordan andyleejordan removed this pull request from the merge queue due to a manual request Feb 9, 2023
@andyleejordan andyleejordan added this pull request to the merge queue Feb 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2023
@andyleejordan andyleejordan added this pull request to the merge queue Feb 10, 2023
@andyleejordan andyleejordan removed this pull request from the merge queue due to a manual request Feb 11, 2023
@andyleejordan andyleejordan merged commit a13eff2 into main Feb 11, 2023
@andyleejordan andyleejordan deleted the andschwa/static-readonly branch February 11, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Ignore Exclude from the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @SeeminglyScience