-
Notifications
You must be signed in to change notification settings - Fork 234
Display IEnumerables
and IDictionaries
in debugger prettily (with "Raw View" available)
#1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :) thanks for this! In your screen shot it shows a $true
without color. Is that new with this change? or just something separate we need an issue for?
src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs
Outdated
Show resolved
Hide resolved
Pretty sure that's separate, let me check without |
Yep, it is, opened issue PowerShell/vscode-powershell#3703 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again!
Ditto #1636 (comment) |
What tests can we add to cover this @JustinGrote? |
I would say test both an ienumerable and an idictionary and verify that:
|
…ariableDetails.cs Co-authored-by: Patrick Meinecke <[email protected]>
…ariableDetails.cs Co-authored-by: Patrick Meinecke <[email protected]>
…ariableDetails.cs Co-authored-by: Patrick Meinecke <[email protected]>
…ariableDetails.cs Co-authored-by: Patrick Meinecke <[email protected]>
95542b3
to
a92d9d7
Compare
Other test length updates were because their "view" has changed to summarize under the "Raw View" header |
@SeeminglyScience please re-review, code has changed a little to clean up the "Raw View" header, but this is mostly net-new tests. Thanks :) |
@JustinGrote I just added a commit with a couple cleanups. Namely I took out the new |
IEnumerables
and IDictionaries
in debugger prettily (with "Raw View" available)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Justin!
@andschwa thanks, I actually originally wrote it with the optional parameters but I wasn't sure if that was muddling up the original AssertDebuggerStopped with too many code paths, hence the separate function for clarity. All good though! |
It made sense to me cause they're all doing the same thing: asserting the debugger stopped, and then optionally asserting it stopped on the right line (or command). |
Resolves #1633
Adds a "Raw View" expandable to the variable pane much like the C# variable provider to hide "noisy" properties of IEnumerable/IDictionary.
