Skip to content

$true is not highlighted in blue in debugger #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JustinGrote opened this issue Nov 24, 2021 · 4 comments · Fixed by PowerShell/PowerShellEditorServices#1636
Closed

$true is not highlighted in blue in debugger #3703

JustinGrote opened this issue Nov 24, 2021 · 4 comments · Fixed by PowerShell/PowerShellEditorServices#1636
Labels
Bug: Pre-release Bugs reproducing only in the pre-release extension. Up for Grabs Will shepherd PRs.

Comments

@JustinGrote
Copy link
Collaborator

JustinGrote commented Nov 24, 2021

Issue Type: Bug

image

Latest Preview (maybe earlier) does not show $true highlighted in blue

Extension version: 2021.11.1
VS Code version: Code - Insiders 1.63.0-insider (4e303fcc52269ab578affa6cb1eb455eacab445f, 2021-11-22T05:28:15.683Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info
Item Value
CPUs AMD Ryzen 7 4700U with Radeon Graphics (8 x 1996)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.36GB (2.77GB free)
Process Argv C:\Users\JGrote\Projects\SDMDashboard --crash-reporter-id 4453efaa-0821-4555-88e2-3de8bad9109e
Screen Reader no
VM 0%
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
pythonrunftest32:30365365
pythonf5test824:30361779
javagetstartedt:30350119
pythonvspyt187:30365360
vsaa593:30376534
vsc1dst:30396469
pythonvs932:30404738
vscexrecpromptt3:30397560
vscop804cf:30404767
vs360:30404995

@ghost ghost added the Needs: Triage Maintainer attention needed! label Nov 24, 2021
@JustinGrote JustinGrote added Bug: Pre-release Bugs reproducing only in the pre-release extension. Up for Grabs Will shepherd PRs. and removed Needs: Triage Maintainer attention needed! labels Nov 24, 2021
@JustinGrote
Copy link
Collaborator Author

I'm thinking the VariablePresentationHint is not being set or otherwise presented correctly.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Nov 24, 2021
@JustinGrote
Copy link
Collaborator Author

JustinGrote commented Nov 24, 2021

The colorization is determined by one of two aspects:
https://github.com/microsoft/vscode/blob/57ca9b99d5b6a59f2d2e0f082ae186559f45f1d8/src/vs/workbench/contrib/debug/browser/baseDebugView.ts#L68-L78

  1. If the "type" property is literally boolean
  2. If it matches a regex that is explicitly 'true' or 'false'

Since the value is presented as $true instead of true, option 2 doesn't happen, so it's likely a flaw in option 1 type assignment.

@JustinGrote
Copy link
Collaborator Author

Hmmm....
image
image
image

@JustinGrote
Copy link
Collaborator Author

For why it works at all, this is actually a vscode bug:
microsoft/vscode#137818

To resolve, we should be providing special type strings to vscode rather than the default .NET type string
https://github.com/microsoft/vscode/blob/57ca9b99d5b6a59f2d2e0f082ae186559f45f1d8/src/vs/workbench/contrib/debug/browser/baseDebugView.ts#L68-L78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Pre-release Bugs reproducing only in the pre-release extension. Up for Grabs Will shepherd PRs.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants